netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Leigh Brown <leigh@solinno.co.uk>
To: linux-arm-kernel@lists.infradead.org
Cc: Leigh Brown <leigh@solinno.co.uk>,
	Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
	netdev@vger.kernel.org, sebastian.hesselbarth@gmail.com
Subject: [PATCH RFC v2 0/4] MDIO bus timeout issues on Dreamplug
Date: Thu, 24 Oct 2013 19:09:30 +0100	[thread overview]
Message-ID: <cover.1382637156.git.leigh@solinno.co.uk> (raw)
In-Reply-To: <cover.1382199042.git.leigh@solinno.co.uk>

Thanks to the comment from Sebastian I did some more investigation and
discovered that almost everything about my analysis was wrong (woops).
The patch itself wasn't too bad though.

In terms of timings, I don't believe the timeout was due to the SMI bus
taking too long to respond because when I have repeated my testing
(this time disabling interrupts whilst waiting), I have found that the
maximum time that my Dreamplug takes to respond was about 95us (and
43us on the Mirabox, which polls).  So I think the root cause of the 
problem was that interrupt handler was interfering with the polling in 
some way.

I have therefore amended the first patch to use usleep_range to sleep
instead of busy wait as suggested by Sebastian, and set the timeout to
1ms.  I've tested this on both the Dreamplug and Mirabox and have seen
no timeouts at all.

The second, third and fourth patches are pretty much the same as before.

If I receive no comments who do I submit this to for inclusion?

Regards,

Leigh.

Leigh Brown (4):
  net: mvmdio: make orion_mdio_wait_ready consistent
  net: mvmdio: orion_mdio_ready: remove manual poll
  net: mvmdio: slight optimisation of orion_mdio_write
  net: mvmdio: doc: mvmdio now used by mv643xx_eth

 drivers/net/ethernet/marvell/mvmdio.c |  107 ++++++++++++++++-----------------
 1 file changed, 52 insertions(+), 55 deletions(-)

-- 
1.7.10.4

  parent reply	other threads:[~2013-10-24 18:10 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-19 16:23 [PATCH RFC 0/4] MDIO bus timeout issues on Dreamplug Leigh Brown
2013-10-19 16:23 ` [PATCH RFC 1/4] net: mvmdio: make orion_mdio_wait_ready consistent Leigh Brown
2013-10-21  7:13   ` Sebastian Hesselbarth
2013-10-19 16:23 ` [PATCH RFC 2/4] net: mvmdio: orion_mdio_ready: remove manual poll Leigh Brown
2013-10-19 16:23 ` [PATCH RFC 3/4] net: mvmdio: slight optimisation of orion_mdio_write Leigh Brown
2013-10-19 16:23 ` [PATCH RFC 4/4] net: mvmdio: doc: mvmdio now used by mv643xx_eth Leigh Brown
2013-10-24 18:09 ` Leigh Brown [this message]
2013-10-24 21:25   ` [PATCH RFC v2 0/4] MDIO bus timeout issues on Dreamplug Jason Cooper
2013-10-29  9:33   ` [PATCH v3 0/4] Fix " Leigh Brown
2013-10-29 22:54     ` David Miller
2013-10-29  9:33   ` [PATCH v3 1/4] net: mvmdio: make orion_mdio_wait_ready consistent Leigh Brown
2013-10-29  9:33   ` [PATCH v3 2/4] net: mvmdio: orion_mdio_ready: remove manual poll Leigh Brown
2013-10-29  9:33   ` [PATCH v3 3/4] net: mvmdio: slight optimisation of orion_mdio_write Leigh Brown
2013-10-29  9:33   ` [PATCH v3 4/4] net: mvmdio: doc: mvmdio now used by mv643xx_eth Leigh Brown
2013-10-24 18:09 ` [PATCH RFC v2 1/4] net: mvmdio: make orion_mdio_wait_ready consistent Leigh Brown
2013-10-26  5:44   ` David Miller
2013-10-24 18:09 ` [PATCH RFC v2 2/4] net: mvmdio: orion_mdio_ready: remove manual poll Leigh Brown
2013-10-24 18:09 ` [PATCH RFC v2 3/4] net: mvmdio: slight optimisation of orion_mdio_write Leigh Brown
2013-10-26  5:45   ` David Miller
2013-10-24 18:09 ` [PATCH RFC v2 4/4] net: mvmdio: doc: mvmdio now used by mv643xx_eth Leigh Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1382637156.git.leigh@solinno.co.uk \
    --to=leigh@solinno.co.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=netdev@vger.kernel.org \
    --cc=sebastian.hesselbarth@gmail.com \
    --cc=thomas.petazzoni@free-electrons.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).