netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Michal Kubecek <mkubecek@suse.cz>
To: "David S. Miller" <davem@davemloft.net>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	Jay Vosburgh <j.vosburgh@gmail.com>,
	Veaceslav Falico <vfalico@gmail.com>,
	Andy Gospodarek <andy@greyhouse.net>,
	Jiri Pirko <jiri@resnulli.us>
Subject: [PATCH net-next 0/3] dev_disable_lro() improvements for stacked devices
Date: Tue, 11 Nov 2014 09:21:30 +0100 (CET)	[thread overview]
Message-ID: <cover.1415692212.git.mkubecek@suse.cz> (raw)

Large receive offloading is known to cause problems if received packets
are passed to other host. Therefore the kernel disables it by calling
dev_disable_lro() whenever a network device is enslaved in a bridge or
forwarding is enabled for it (or globally). For virtual devices we need
to disable LRO on the underlying physical device (which is actually
receiving the packets).

Current dev_disable_lro() code handles this propagation for a vlan
(including 802.1ad nested vlan), macvlan or a vlan on top of a macvlan.
This patch adds LRO disabling propagation for

  - macvlan on top of a vlan or any stacked combination of those
  - bonding
  - teaming

In the bonding and teaming case, it is necessary to disable LRO not only
on slaves when dev_disable_lro() is called but also on any slave (port)
added later.

Michal Kubecek (3):
  net: handle more general stacking in dev_disable_lro()
  team: add helper to check if device is a team master
  net: propagate LRO disabling to bond and team slaves

 drivers/net/bonding/bond_main.c |  3 +++
 drivers/net/team/team.c         |  6 +++++-
 include/linux/netdevice.h       |  7 +++++++
 net/core/dev.c                  | 31 ++++++++++++++++++++++---------
 4 files changed, 37 insertions(+), 10 deletions(-)

-- 
1.8.4.5

             reply	other threads:[~2014-11-11  8:21 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-11  8:21 Michal Kubecek [this message]
2014-11-11  8:21 ` [PATCH net-next 1/3] net: handle more general stacking in dev_disable_lro() Michal Kubecek
2014-11-11  8:21 ` [PATCH net-next 2/3] team: add helper to check if device is a team master Michal Kubecek
2014-11-11  8:22 ` [PATCH net-next 3/3] net: propagate LRO disabling to bond and team slaves Michal Kubecek
2014-11-11  9:05 ` [PATCH net-next 0/3] dev_disable_lro() improvements for stacked devices Veaceslav Falico
2014-11-11  9:34   ` Michal Kubecek
2014-11-12  2:47     ` David Miller
2014-11-12 13:15       ` Michal Kubecek
2014-11-12 20:08         ` David Miller
2014-11-13  6:54       ` [PATCH net-next v2] net: generic dev_disable_lro() stacked device handling Michal Kubecek
2014-11-13  7:15         ` Veaceslav Falico
2014-11-13 19:49         ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1415692212.git.mkubecek@suse.cz \
    --to=mkubecek@suse.cz \
    --cc=andy@greyhouse.net \
    --cc=davem@davemloft.net \
    --cc=j.vosburgh@gmail.com \
    --cc=jiri@resnulli.us \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=vfalico@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).