From: Jiri Benc <jbenc@redhat.com>
To: netdev@vger.kernel.org
Cc: Thomas Graf <tgraf@suug.ch>, Roopa Prabhu <roopa@cumulusnetworks.com>
Subject: [PATCH net 0/2] lwtunnel: make it really work, for IPv4
Date: Tue, 22 Sep 2015 18:12:10 +0200 [thread overview]
Message-ID: <cover.1442936392.git.jbenc@redhat.com> (raw)
One of the selling points of lwtunnel was the ability to specify the tunnel
destination using routes. However, this doesn't really work currently, as
ARP and ndisc replies are not handled correctly. ARP and ndisc replies won't
have tunnel metadata attached, thus they will be sent out with the default
parameters or not sent at all, either way never reaching the requester.
Most of the egress tunnel parameters can be inferred from the ingress
metada. The only and important exception is UDP ports. This patchset infers
the egress data from the ingress data and disallow settings of UDP ports in
tunnel routes. If there's a need for different UDP ports, a new interface
needs to be created for each port combination. Note that it's still possible
to specify the UDP ports to use, it just needs to be done while creating the
vxlan/geneve interface.
This covers only ARPs. IPv6 ndisc has the same problem but is harder to
solve, as there's already dst attached to outgoing skbs. Ideas to solve this
are welcome.
Jiri Benc (2):
ipv4: send arp replies to the correct tunnel
lwtunnel: remove source and destination UDP port config option
include/net/ip_tunnels.h | 2 ++
include/uapi/linux/lwtunnel.h | 4 ----
net/ipv4/arp.c | 39 ++++++++++++++++++++------------
net/ipv4/ip_tunnel_core.c | 52 +++++++++++++++++++++++--------------------
4 files changed, 55 insertions(+), 42 deletions(-)
--
1.8.3.1
next reply other threads:[~2015-09-22 16:12 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-22 16:12 Jiri Benc [this message]
2015-09-22 16:12 ` [PATCH net 1/2] ipv4: send arp replies to the correct tunnel Jiri Benc
2015-09-23 8:10 ` Thomas Graf
2015-09-22 16:12 ` [PATCH net 2/2] lwtunnel: remove source and destination UDP port config option Jiri Benc
2015-09-23 8:12 ` Thomas Graf
2015-09-23 4:39 ` [PATCH net 0/2] lwtunnel: make it really work, for IPv4 Eric W. Biederman
2015-09-23 8:09 ` Thomas Graf
2015-09-23 12:17 ` Eric W. Biederman
2015-09-23 14:29 ` Jiri Benc
2015-09-23 17:42 ` Eric W. Biederman
2015-09-23 20:54 ` Jiri Benc
2015-09-23 21:09 ` Eric W. Biederman
2015-09-23 23:08 ` Thomas Graf
2015-09-24 5:54 ` Eric W. Biederman
2015-09-24 8:19 ` Jiri Benc
2015-09-24 8:35 ` Jiri Benc
2015-09-23 8:08 ` Thomas Graf
2015-09-24 21:32 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1442936392.git.jbenc@redhat.com \
--to=jbenc@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=roopa@cumulusnetworks.com \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).