From: Sowmini Varadhan <sowmini.varadhan@oracle.com>
To: eric.dumazet@gmail.com, netdev@vger.kernel.org
Cc: sowmini.varadhan@oracle.com
Subject: [PATCH RFC net-next 0/2] pskb_extract() helper function.
Date: Mon, 18 Apr 2016 06:21:07 -0700 [thread overview]
Message-ID: <cover.1460928360.git.sowmini.varadhan@oracle.com> (raw)
This patchset follows up on the discussion in
https://www.mail-archive.com/netdev@vger.kernel.org/msg105090.html
For RDS-TCP, we have to deal with the full gamut of
nonlinear sk_buffs, including all the frag_list variants.
Also, the parent skb has to remain unchanged, while the clone
is queued for Rx on the PF_RDS socket.
Patch 1 of this patchset adds a pskb_extract() function that
does all this without the redundant memcpy's in pskb_expand_head()
and __pskb_pull_tail().
A further optimization is also possible by inlining pskb_trim()
itself into pskb_carve() and thus avoiding the needless copy
of trailer frags/pages that will then get trimmed away. I am
deferring that optimization for the next iteration, and would
like to get feedback on this first pass, which by itself gives
a noticeable perf boost.
Sowmini Varadhan (2):
Add pskb_extract() helper function
Call pskb_extract() helper function
include/linux/skbuff.h | 2 +
net/core/skbuff.c | 248 ++++++++++++++++++++++++++++++++++++++++++++++++
net/rds/tcp_recv.c | 14 +--
3 files changed, 253 insertions(+), 11 deletions(-)
next reply other threads:[~2016-04-18 13:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-18 13:21 Sowmini Varadhan [this message]
2016-04-18 13:21 ` [PATCH RFC net-next 1/2] skbuff: Add pskb_extract() helper function Sowmini Varadhan
2016-04-18 13:21 ` [PATCH RFC net-next 2/2] RDS: TCP: Call " Sowmini Varadhan
2016-04-18 13:28 ` [PATCH RFC net-next 0/2] " Marcelo Ricardo Leitner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1460928360.git.sowmini.varadhan@oracle.com \
--to=sowmini.varadhan@oracle.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).