netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Leonard Crestez <leonard.crestez@nxp.com>
To: Shawn Guo <shawnguo@kernel.org>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Andrew Lunn <andrew@lunn.ch>, Andy Duan <fugang.duan@nxp.com>
Cc: Johan Hovold <johan@kernel.org>,
	Alexandre Belloni <alexandre.belloni@free-electrons.com>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Fabio Estevam <fabio.estevam@nxp.com>, <netdev@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>
Subject: [PATCH 0/2] ARM: imx6ul-14x14-evk: Fix suspend over nfs by phy cleanup
Date: Tue, 30 May 2017 20:34:02 +0300	[thread overview]
Message-ID: <cover.1496164448.git.leonard.crestez@nxp.com> (raw)

Right now attempting doing suspend/resume while root is mounted over NFS hangs
on imx6ul-14x14-evk. This is happening because ksz8081 phy fixups are lost on
resume.

Fix this by using equivalent devicetree properties instead of a phy fixup and
handling those properties on resume in the micrel driver.

Other solutions would be possible such as having a way to run phy fixups again
on resume. This alternative is precisely targeted.

In theory it might now be possible to remove the phy fixup from mach-imx6ul
entirely but it is possible that this would break other imx6ul boards which use
the same phy. The solution would be to patch their dts but it's not clear how
to identify affected boards.

This code is shared with imx6ull-14x14-evk but 6ull suspend needs an unrelated
patch: https://lkml.org/lkml/2017/5/30/584

Leonard Crestez (2):
  ARM: dts: imx6ul-14x14-evk: Add ksz8081 phy properties
  net: phy: micrel: Restore led_mode and clk_sel on resume

 arch/arm/boot/dts/imx6ul-14x14-evk.dts |  6 ++++++
 drivers/net/phy/micrel.c               | 15 +++++++++++++++
 2 files changed, 21 insertions(+)

-- 
2.7.4

             reply	other threads:[~2017-05-30 17:34 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-30 17:34 Leonard Crestez [this message]
2017-05-30 17:34 ` [PATCH 1/2] ARM: dts: imx6ul-14x14-evk: Add ksz8081 phy properties Leonard Crestez
2017-05-30 18:10   ` Florian Fainelli
2017-05-30 22:20     ` Leonard Crestez
2017-05-31  4:08   ` Fabio Estevam
2017-05-30 17:34 ` [PATCH 2/2] net: phy: micrel: Restore led_mode and clk_sel on resume Leonard Crestez
2017-05-30 18:05   ` Florian Fainelli
2017-05-30 22:08     ` Leonard Crestez
2017-05-30 22:19       ` Florian Fainelli
2017-05-30 23:14         ` Leonard Crestez
2017-05-30 18:12   ` Fabio Estevam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1496164448.git.leonard.crestez@nxp.com \
    --to=leonard.crestez@nxp.com \
    --cc=alexandre.belloni@free-electrons.com \
    --cc=andrew@lunn.ch \
    --cc=f.fainelli@gmail.com \
    --cc=fabio.estevam@nxp.com \
    --cc=fugang.duan@nxp.com \
    --cc=johan@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=p.zabel@pengutronix.de \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).