From: Finn Thain <fthain@telegraphics.com.au>
To: "David S. Miller" <davem@davemloft.net>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH net v2 0/9] Fixes, cleanup and modernization for some legacy ethernet NIC drivers
Date: Thu, 5 Oct 2017 21:11:05 -0400 (EDT) [thread overview]
Message-ID: <cover.1507211120.git.fthain@telegraphics.com.au> (raw)
This patch series fixes some logging bugs and adds some missing message
severity levels.
There are also cleanup patches for dead code and some Kconfig cruft.
Custom debug message logging is converted to netif_* calls to reduce
code duplication.
All up, about 150 lines of code are eliminated.
This patch series has been tested on various Macs to provide coverage
of the changes to lib8390.c, mac8390.c, macsonic.c, sonic.[ch] and
macmace.c. All other changes were only compile-tested but these are
fairly trivial or are confined to log messages or both.
Changes since v1:
- Keep the once_is_enough test in mac89x0.c.
- Add tested-by tags.
- Move netdev_info() call to correct branch in macmace.c.
Finn Thain (9):
net/smc9194: Remove bogus CONFIG_MAC reference
net/mac89x0: Remove dead or unreachable code
net/mac89x0: Fix and modernize log messages
net/mac89x0: Replace custom debug logging with netif_* calls
net/macmace: Fix and cleanup log messages
net/sonic: Cleanup and modernize log messages
net/sonic: Replace custom debug logging with netif_* calls
net/8390: Fix redundant code
net/mac8390: Fix log messages
drivers/net/ethernet/8390/ax88796.c | 3 -
drivers/net/ethernet/8390/axnet_cs.c | 2 -
drivers/net/ethernet/8390/etherh.c | 17 -----
drivers/net/ethernet/8390/hydra.c | 4 --
drivers/net/ethernet/8390/lib8390.c | 2 +
drivers/net/ethernet/8390/mac8390.c | 42 ++++++-------
drivers/net/ethernet/8390/mcf8390.c | 4 --
drivers/net/ethernet/8390/pcnet_cs.c | 4 --
drivers/net/ethernet/8390/zorro8390.c | 5 --
drivers/net/ethernet/apple/macmace.c | 16 +++--
drivers/net/ethernet/cirrus/mac89x0.c | 104 +++++++++----------------------
drivers/net/ethernet/natsemi/jazzsonic.c | 26 ++------
drivers/net/ethernet/natsemi/macsonic.c | 45 ++++---------
drivers/net/ethernet/natsemi/sonic.c | 92 +++++++++++++--------------
drivers/net/ethernet/natsemi/sonic.h | 2 +
drivers/net/ethernet/natsemi/xtsonic.c | 28 +++------
drivers/net/ethernet/smsc/Kconfig | 2 +-
17 files changed, 127 insertions(+), 271 deletions(-)
--
2.13.5
next reply other threads:[~2017-10-06 1:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-06 1:11 Finn Thain [this message]
2017-10-06 1:11 ` [PATCH net v2 6/9] net/sonic: Cleanup and modernize log messages Finn Thain
2017-10-06 1:11 ` [PATCH net v2 1/9] net/smc9194: Remove bogus CONFIG_MAC reference Finn Thain
2017-10-06 1:11 ` [PATCH net v2 3/9] net/mac89x0: Fix and modernize log messages Finn Thain
2017-10-06 4:08 ` David Miller
2017-10-06 11:06 ` Finn Thain
2017-10-06 1:11 ` [PATCH net v2 8/9] net/8390: Fix redundant code Finn Thain
2017-10-06 1:11 ` [PATCH net v2 5/9] net/macmace: Fix and cleanup log messages Finn Thain
2017-10-06 1:11 ` [PATCH net v2 9/9] net/mac8390: Fix " Finn Thain
2017-10-06 1:11 ` [PATCH net v2 7/9] net/sonic: Replace custom debug logging with netif_* calls Finn Thain
2017-10-06 1:11 ` [PATCH net v2 2/9] net/mac89x0: Remove dead or unreachable code Finn Thain
2017-10-06 1:11 ` [PATCH net v2 4/9] net/mac89x0: Replace custom debug logging with netif_* calls Finn Thain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1507211120.git.fthain@telegraphics.com.au \
--to=fthain@telegraphics.com.au \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).