From: Sowmini Varadhan <sowmini.varadhan@oracle.com>
To: sowmini.varadhan@oracle.com, netdev@vger.kernel.org,
willemdebruijn.kernel@gmail.com
Cc: davem@davemloft.net, rds-devel@oss.oracle.com,
santosh.shilimkar@oracle.com
Subject: [PATCH v3 net-next 0/7] RDS: zerocopy support
Date: Thu, 15 Feb 2018 10:49:31 -0800 [thread overview]
Message-ID: <cover.1518718761.git.sowmini.varadhan@oracle.com> (raw)
This is version 3 of the series, following up on review comments for
http://patchwork.ozlabs.org/project/netdev/list/?series=28530
Review comments addressed
Patch 4
- fix fragile use of skb->cb[], do not set ee_code incorrectly.
Patch 5:
- remove needless bzero of skb->cb[], consolidate err cleanup
A brief overview of this feature follows.
This patch series provides support for MSG_ZERCOCOPY
on a PF_RDS socket based on the APIs and infrastructure added
by Commit f214f915e7db ("tcp: enable MSG_ZEROCOPY")
For single threaded rds-stress testing using rds-tcp with the
ixgbe driver using 1M message sizes (-a 1M -q 1M) preliminary
results show that there is a significant reduction in latency: about
90 usec with zerocopy, compared with 200 usec without zerocopy.
This patchset modifies the above for zerocopy in the following manner.
- if the MSG_ZEROCOPY flag is specified with rds_sendmsg(), and,
- if the SO_ZEROCOPY socket option has been set on the PF_RDS socket,
application pages sent down with rds_sendmsg are pinned. The pinning
uses the accounting infrastructure added by a91dbff551a6 ("sock: ulimit
on MSG_ZEROCOPY pages"). The message is unpinned when all references
to the message go down to 0, and the message is freed by rds_message_purge.
A multithreaded application using this infrastructure must send down
a unique 32 bit cookie as ancillary data with each sendmsg invocation.
The format of this ancillary data is described in Patch 5 of the series.
The cookie is passed up to the application on the sk_error_queue when
the message is unpinned, indicating to the application that it is now
safe to free/reuse the message buffer. The details of the completion
notification are provided in Patch 4 of this series.
Sowmini Varadhan (7):
skbuff: export mm_[un]account_pinned_pages for other modules
rds: hold a sock ref from rds_message to the rds_sock
sock: permit SO_ZEROCOPY on PF_RDS socket
rds: support for zcopy completion notification
rds: zerocopy Tx support.
selftests/net: add support for PF_RDS sockets
selftests/net: add zerocopy support for PF_RDS test case
include/linux/skbuff.h | 3 +
include/uapi/linux/errqueue.h | 2 +
include/uapi/linux/rds.h | 1 +
net/core/skbuff.c | 6 +-
net/core/sock.c | 25 +++---
net/rds/af_rds.c | 2 +
net/rds/message.c | 132 ++++++++++++++++++++++++++-
net/rds/rds.h | 17 ++++-
net/rds/recv.c | 2 +
net/rds/send.c | 51 ++++++++---
tools/testing/selftests/net/msg_zerocopy.c | 133 ++++++++++++++++++++++++++-
11 files changed, 339 insertions(+), 35 deletions(-)
next reply other threads:[~2018-02-15 20:34 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-15 18:49 Sowmini Varadhan [this message]
2018-02-15 18:49 ` [PATCH v3 net-next 1/7] skbuff: export mm_[un]account_pinned_pages for other modules Sowmini Varadhan
2018-02-15 20:41 ` Willem de Bruijn
2018-02-15 18:49 ` [PATCH v3 net-next 2/7] rds: hold a sock ref from rds_message to the rds_sock Sowmini Varadhan
2018-02-15 19:45 ` Santosh Shilimkar
2018-02-15 18:49 ` [PATCH v3 net-next 3/7] sock: permit SO_ZEROCOPY on PF_RDS socket Sowmini Varadhan
2018-02-15 20:41 ` Willem de Bruijn
2018-02-15 18:49 ` [PATCH v3 net-next 4/7] rds: support for zcopy completion notification Sowmini Varadhan
2018-02-15 19:46 ` Santosh Shilimkar
2018-02-15 20:42 ` Willem de Bruijn
2018-02-15 18:49 ` [PATCH v3 net-next 5/7] rds: zerocopy Tx support Sowmini Varadhan
2018-02-15 19:47 ` Santosh Shilimkar
2018-02-15 20:42 ` Willem de Bruijn
2018-02-15 18:49 ` [PATCH v3 net-next 6/7] selftests/net: add support for PF_RDS sockets Sowmini Varadhan
2018-02-15 20:42 ` Willem de Bruijn
2018-02-15 18:49 ` [PATCH v3 net-next 7/7] selftests/net: add zerocopy support for PF_RDS test case Sowmini Varadhan
2018-02-15 20:43 ` Willem de Bruijn
2018-02-16 21:13 ` [PATCH v3 net-next 0/7] RDS: zerocopy support David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1518718761.git.sowmini.varadhan@oracle.com \
--to=sowmini.varadhan@oracle.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=rds-devel@oss.oracle.com \
--cc=santosh.shilimkar@oracle.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).