From: Kevin Easton <kevin@guarana.org>
To: Steffen Klassert <steffen.klassert@secunet.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 0/2] af_key: Fix for sadb_key memcpy read overrun
Date: Mon, 26 Mar 2018 07:39:06 -0400 [thread overview]
Message-ID: <cover.1522063171.git.kevin@guarana.org> (raw)
As found by syzbot, af_key does not properly validate the key length in
sadb_key messages from userspace. This can result in copying from beyond
the end of the sadb_key part of the message, or indeed beyond the end of
the entire packet.
Kevin Easton (2):
af_key: Use DIV_ROUND_UP() instead of open-coded equivalent
af_key: Always verify length of provided sadb_key
net/key/af_key.c | 58 ++++++++++++++++++++++++++++++++++++++++----------------
1 file changed, 42 insertions(+), 16 deletions(-)
--
2.8.1
next reply other threads:[~2018-03-26 11:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-26 11:39 Kevin Easton [this message]
2018-03-26 11:39 ` [PATCH 1/2] af_key: Use DIV_ROUND_UP() instead of open-coded equivalent Kevin Easton
2018-03-28 5:59 ` Steffen Klassert
2018-03-29 1:35 ` Kevin Easton
2018-04-06 4:31 ` Steffen Klassert
2018-03-26 11:39 ` [PATCH 2/2] af_key: Always verify length of provided sadb_key Kevin Easton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1522063171.git.kevin@guarana.org \
--to=kevin@guarana.org \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=steffen.klassert@secunet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).