From: Guillaume Nault <g.nault@alphalink.fr>
To: netdev@vger.kernel.org
Cc: James Chapman <jchapman@katalix.com>, Tom Parkin <tparkin@katalix.com>
Subject: [PATCH net 0/2] l2tp: tunnel creation fixes
Date: Tue, 10 Apr 2018 21:01:07 +0200 [thread overview]
Message-ID: <cover.1523385906.git.g.nault@alphalink.fr> (raw)
L2TP tunnel creation is racy. We need to make sure that the tunnel
returned by l2tp_tunnel_create() isn't going to be freed while the
caller is using it. This is done in patch #1, by separating tunnel
creation from tunnel registration.
With the tunnel registration code in place, we can now check for
duplicate tunnels in a race-free way. This is done in patch #2, which
incidentally removes the last use of l2tp_tunnel_find().
Guillaume Nault (2):
l2tp: fix races in tunnel creation
l2tp: fix race in duplicate tunnel detection
net/l2tp/l2tp_core.c | 225 +++++++++++++++++-----------------------
net/l2tp/l2tp_core.h | 4 +-
net/l2tp/l2tp_netlink.c | 22 ++--
net/l2tp/l2tp_ppp.c | 9 ++
4 files changed, 123 insertions(+), 137 deletions(-)
--
2.17.0
next reply other threads:[~2018-04-10 19:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-10 19:01 Guillaume Nault [this message]
2018-04-10 19:01 ` [PATCH net 1/2] l2tp: fix races in tunnel creation Guillaume Nault
2018-04-10 19:01 ` [PATCH net 2/2] l2tp: fix race in duplicate tunnel detection Guillaume Nault
2018-04-11 21:42 ` [PATCH net 0/2] l2tp: tunnel creation fixes David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1523385906.git.g.nault@alphalink.fr \
--to=g.nault@alphalink.fr \
--cc=jchapman@katalix.com \
--cc=netdev@vger.kernel.org \
--cc=tparkin@katalix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).