From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from zimbra.alphalink.fr ([217.15.80.77]:40379 "EHLO zimbra.alphalink.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752062AbeDJTBK (ORCPT ); Tue, 10 Apr 2018 15:01:10 -0400 Date: Tue, 10 Apr 2018 21:01:07 +0200 From: Guillaume Nault To: netdev@vger.kernel.org Cc: James Chapman , Tom Parkin Subject: [PATCH net 0/2] l2tp: tunnel creation fixes Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Sender: netdev-owner@vger.kernel.org List-ID: L2TP tunnel creation is racy. We need to make sure that the tunnel returned by l2tp_tunnel_create() isn't going to be freed while the caller is using it. This is done in patch #1, by separating tunnel creation from tunnel registration. With the tunnel registration code in place, we can now check for duplicate tunnels in a race-free way. This is done in patch #2, which incidentally removes the last use of l2tp_tunnel_find(). Guillaume Nault (2): l2tp: fix races in tunnel creation l2tp: fix race in duplicate tunnel detection net/l2tp/l2tp_core.c | 225 +++++++++++++++++----------------------- net/l2tp/l2tp_core.h | 4 +- net/l2tp/l2tp_netlink.c | 22 ++-- net/l2tp/l2tp_ppp.c | 9 ++ 4 files changed, 123 insertions(+), 137 deletions(-) -- 2.17.0