From mboxrd@z Thu Jan 1 00:00:00 1970 From: Petr Machata Subject: [PATCH net-next 0/2] bridge: FDB: Notify about removal of non-user-added entries Date: Tue, 01 May 2018 19:04:19 +0200 Message-ID: Mime-Version: 1.0 Content-Type: text/plain Cc: ivecera@redhat.com, davem@davemloft.net, stephen@networkplumber.org, andrew@lunn.ch, vivien.didelot@savoirfairelinux.com, f.fainelli@gmail.com, jiri@resnulli.us To: netdev@vger.kernel.org Return-path: Received: from mail-ve1eur01on0067.outbound.protection.outlook.com ([104.47.1.67]:33472 "EHLO EUR01-VE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756046AbeEARE2 (ORCPT ); Tue, 1 May 2018 13:04:28 -0400 Sender: netdev-owner@vger.kernel.org List-ID: Device drivers may generally need to keep in sync with bridge's FDB. In particular, for its offload of tc mirror action where the mirrored-to device is a gretap device, mlxsw needs to listen to a number of events. SWITCHDEV_FDB_{ADD,DEL}_TO_DEVICE would be a natural notification to listen to in order to keep up with FDB updates. However, for removal of FDB entries added due to device activity (as opposed to explicit addition through "bridge fdb add" or similar), there are no notifications. Thus in patch #1, add the "added_by_user" field to switchdev notifications sent for FDB activity. Adapt drivers to ignore activity on non-user-added entries, to maintain the current behavior. Specifically in case of mlxsw, allow mlxsw_sp_span_respin() call for any and all FDB updates. In patch #2, change the bridge driver to actually emit notifications for these FDB entries. Take care not to send notification for bridge updates that itself originate in SWITCHDEV_FDB_*_TO_BRIDGE events. Petr Machata (2): switchdev: Add fdb.added_by_user to switchdev notifications net: bridge: Notify about !added_by_user FDB entries .../ethernet/mellanox/mlxsw/spectrum_switchdev.c | 4 +++ drivers/net/ethernet/rocker/rocker_main.c | 2 ++ include/net/switchdev.h | 1 + net/bridge/br.c | 4 +-- net/bridge/br_fdb.c | 40 +++++++++++++++------- net/bridge/br_private.h | 4 +-- net/bridge/br_switchdev.c | 12 ++++--- net/dsa/slave.c | 5 ++- 8 files changed, 50 insertions(+), 22 deletions(-) -- 2.4.11