From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guillaume Nault Subject: [PATCH net 0/2] l2tp: l2tp_ppp must ignore non-PPP sessions Date: Fri, 15 Jun 2018 15:39:15 +0200 Message-ID: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: James Chapman To: netdev@vger.kernel.org Return-path: Received: from zimbra.alphalink.fr ([217.15.80.77]:43942 "EHLO zimbra.alphalink.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S936144AbeFONjS (ORCPT ); Fri, 15 Jun 2018 09:39:18 -0400 Content-Disposition: inline Sender: netdev-owner@vger.kernel.org List-ID: The original L2TP code was written for version 2 of the protocol, which could only carry PPP sessions. Then L2TPv3 generalised the protocol so that it could transport different kinds of pseudo-wires. But parts of the l2tp_ppp module still break in presence of non-PPP sessions. Assuming L2TPv2 tunnels can only transport PPP sessions is right, but l2tp_netlink failed to ensure that (fixed in patch 1). When retrieving a session from an arbitrary tunnel, l2tp_ppp needs to filter out non-PPP sessions (last occurrence fixed in patch 2). Guillaume Nault (2): l2tp: reject creation of non-PPP sessions on L2TPv2 tunnels l2tp: filter out non-PPP sessions in pppol2tp_tunnel_ioctl() net/l2tp/l2tp_netlink.c | 6 ++++++ net/l2tp/l2tp_ppp.c | 2 +- 2 files changed, 7 insertions(+), 1 deletion(-) -- 2.17.1