From: Dave Stevenson <dave.stevenson@raspberrypi.org>
To: woojung.huh@microchip.com, UNGLinuxDriver@microchip.com,
davem@davemloft.net, netdev@vger.kernel.org
Cc: Dave Stevenson <dave.stevenson@raspberrypi.org>
Subject: [PATCH 0/4] lan78xx minor fixes
Date: Mon, 25 Jun 2018 15:07:11 +0100 [thread overview]
Message-ID: <cover.1529935234.git.dave.stevenson@raspberrypi.org> (raw)
This is a small set of patches for the Microchip LAN78xx chip,
as used in the Raspberry Pi 3B+.
The main debug/discussion was on
https://github.com/raspberrypi/linux/issues/2458
Initial symptoms were that VLANs were very unreliable.
A couple of things were found:
- firstly that the hardware timeout value set failed to
take into account the VLAN tag, so a full MTU packet
would be timed out.
- second was that regular checksum failures were being
reported. Disabling checksum offload confirmed that
the checksums were valid, and further experimentation
identified that it was only if the VLAN tags were being
passed through to the kernel that there were issues.
The hardware supports VLAN filtering and tag stripping,
therefore those have been implemented (much of the work
was already done), and the driver drops back to s/w
checksums should the choice be made not to use the h/w
VLAN stripping.
Dave Stevenson (4):
net: lan78xx: Allow for VLAN headers in timeout calcs
net: lan78xx: Add support for VLAN filtering.
net: lan78xx: Add support for VLAN tag stripping.
net: lan78xx: Use s/w csum check on VLANs without tag stripping
drivers/net/usb/lan78xx.c | 37 ++++++++++++++++++++++++++++++++++---
1 file changed, 34 insertions(+), 3 deletions(-)
--
2.7.4
next reply other threads:[~2018-06-25 17:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-25 14:07 Dave Stevenson [this message]
2018-06-25 14:07 ` [PATCH 1/4] net: lan78xx: Allow for VLAN headers in timeout calcs Dave Stevenson
2018-06-25 14:07 ` [PATCH 2/4] net: lan78xx: Add support for VLAN filtering Dave Stevenson
2018-06-25 14:07 ` [PATCH 3/4] net: lan78xx: Add support for VLAN tag stripping Dave Stevenson
2018-06-25 14:07 ` [PATCH 4/4] net: lan78xx: Use s/w csum check on VLANs without " Dave Stevenson
2018-06-26 13:54 ` [PATCH 0/4] lan78xx minor fixes David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1529935234.git.dave.stevenson@raspberrypi.org \
--to=dave.stevenson@raspberrypi.org \
--cc=UNGLinuxDriver@microchip.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).