From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Stevenson Subject: [PATCH 0/4] lan78xx minor fixes Date: Mon, 25 Jun 2018 15:07:11 +0100 Message-ID: Cc: Dave Stevenson To: woojung.huh@microchip.com, UNGLinuxDriver@microchip.com, davem@davemloft.net, netdev@vger.kernel.org Return-path: Received: from mx07-00252a01.pphosted.com ([62.209.51.214]:40400 "EHLO mx07-00252a01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964835AbeFYRzM (ORCPT ); Mon, 25 Jun 2018 13:55:12 -0400 Received: from pps.filterd (m0102628.ppops.net [127.0.0.1]) by mx07-00252a01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w5PHrCp4025307 for ; Mon, 25 Jun 2018 18:55:11 +0100 Received: from mail-wm0-f70.google.com (mail-wm0-f70.google.com [74.125.82.70]) by mx07-00252a01.pphosted.com with ESMTP id 2jsbm097ya-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=OK) for ; Mon, 25 Jun 2018 18:55:11 +0100 Received: by mail-wm0-f70.google.com with SMTP id w145-v6so1452709wmw.1 for ; Mon, 25 Jun 2018 10:55:11 -0700 (PDT) Sender: netdev-owner@vger.kernel.org List-ID: This is a small set of patches for the Microchip LAN78xx chip, as used in the Raspberry Pi 3B+. The main debug/discussion was on https://github.com/raspberrypi/linux/issues/2458 Initial symptoms were that VLANs were very unreliable. A couple of things were found: - firstly that the hardware timeout value set failed to take into account the VLAN tag, so a full MTU packet would be timed out. - second was that regular checksum failures were being reported. Disabling checksum offload confirmed that the checksums were valid, and further experimentation identified that it was only if the VLAN tags were being passed through to the kernel that there were issues. The hardware supports VLAN filtering and tag stripping, therefore those have been implemented (much of the work was already done), and the driver drops back to s/w checksums should the choice be made not to use the h/w VLAN stripping. Dave Stevenson (4): net: lan78xx: Allow for VLAN headers in timeout calcs net: lan78xx: Add support for VLAN filtering. net: lan78xx: Add support for VLAN tag stripping. net: lan78xx: Use s/w csum check on VLANs without tag stripping drivers/net/usb/lan78xx.c | 37 ++++++++++++++++++++++++++++++++++--- 1 file changed, 34 insertions(+), 3 deletions(-) -- 2.7.4