From mboxrd@z Thu Jan 1 00:00:00 1970 From: Davide Caratti Subject: [PATCH net 0/2] net/sched: fix NULL dereference in 'goto chain' control action Date: Fri, 6 Jul 2018 21:01:04 +0200 Message-ID: Cc: netdev@vger.kernel.org To: Jiri Pirko , Amir Vadai , "David S. Miller" Return-path: Received: from mx3-rdu2.redhat.com ([66.187.233.73]:41970 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S934201AbeGFTBS (ORCPT ); Fri, 6 Jul 2018 15:01:18 -0400 Sender: netdev-owner@vger.kernel.org List-ID: in a couple of TC actions (i.e. csum and tunnel_key), the control action is stored together with the action-specific configuration data. This avoids a race condition (see [1]), but it causes a crash when 'goto chain' is used with the above actions. Since this race condition is tolerated on the other TC actions (it's present even on actions where the spinlock is still used), storing the control action in the common area should be acceptable for tunnel_key and csum as well. [1] https://www.spinics.net/lists/netdev/msg472047.html Davide Caratti (2): net/sched: act_csum: fix NULL dereference when 'goto chain' is used net/sched: act_tunnel_key: fix NULL dereference when 'goto chain' is used include/net/tc_act/tc_csum.h | 1 - include/net/tc_act/tc_tunnel_key.h | 1 - net/sched/act_csum.c | 6 +++--- net/sched/act_tunnel_key.c | 6 +++--- 4 files changed, 6 insertions(+), 8 deletions(-) -- 2.17.1