netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Abeni <pabeni@redhat.com>
To: netdev@vger.kernel.org
Cc: Jamal Hadi Salim <jhs@mojatatu.com>,
	Cong Wang <xiyou.wangcong@gmail.com>,
	Jiri Pirko <jiri@resnulli.us>,
	Daniel Borkmann <daniel@iogearbox.net>,
	Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>,
	Eyal Birger <eyal.birger@gmail.com>,
	"David S. Miller" <davem@davemloft.net>
Subject: [PATCH net-next v5 0/4] TC: refactor act_mirred packets re-injection
Date: Mon, 30 Jul 2018 14:30:41 +0200	[thread overview]
Message-ID: <cover.1532934532.git.pabeni@redhat.com> (raw)

This series is aimed at improving the act_mirred redirect performances.
Such action is used by OVS to represent TC S/W flows, and it's current largest
bottle-neck is the need for a skb_clone() for each packet.

The first 2 patches introduce some cleanup and safeguards to allow extending 
tca_result - we will use it to store RCU protected redirect information - and
introduce a clear separation between user-space accessible tcfa_action
values and internal values accessible only by the kernel.
Then a new tcfa_action value is introduced: TC_ACT_REINJECT, similar to
TC_ACT_REDIRECT, but preserving the mirred semantic. Such value is not
accessible from user-space.
The last patch exploits the newly introduced infrastructure in the act_mirred
action, to avoid a skb_clone, when possible.

Overall this the above gives a ~10% performance improvement in forwarding tput,
when using the TC S/W datapath.

v1 -> v2:
 - preserve the rcu lock in act_bpf
 - add and use a new action value to reinject the packets, preserving the mirred
   semantic

v2 -> v3:
 - renamed to new action as TC_ACT_REINJECT
 - TC_ACT_REINJECT is not exposed to user-space

v3 -> v4:
 - dropped the TC_ACT_REDIRECT patch
 - report failure via extack, too
 - rename the new action as TC_ACT_REINSERT
 - skip clone only if the control action don't touch tcf_result

v4 -> v5:
 - fix a couple of build issue reported by kbuild bot
 - dont split messages

Paolo Abeni (4):
  net/sched: user-space can't set unknown tcfa_action values
  tc/act: remove unneeded RCU lock in action callback
  net/tc: introduce TC_ACT_REINSERT.
  act_mirred: use TC_ACT_REINSERT when possible

 include/net/act_api.h        |  2 +-
 include/net/pkt_cls.h        |  3 ++
 include/net/sch_generic.h    | 30 +++++++++++++++++++
 include/uapi/linux/pkt_cls.h |  6 ++--
 net/core/dev.c               |  6 +++-
 net/sched/act_api.c          | 14 +++++++++
 net/sched/act_csum.c         | 12 ++------
 net/sched/act_ife.c          |  5 +---
 net/sched/act_mirred.c       | 57 ++++++++++++++++++++++++++++--------
 net/sched/act_sample.c       |  4 +--
 net/sched/act_skbedit.c      | 10 ++-----
 net/sched/act_skbmod.c       | 21 ++++++-------
 net/sched/act_tunnel_key.c   |  6 +---
 net/sched/act_vlan.c         | 19 +++++-------
 14 files changed, 126 insertions(+), 69 deletions(-)

-- 
2.17.1

             reply	other threads:[~2018-07-30 14:05 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-30 12:30 Paolo Abeni [this message]
2018-07-30 12:30 ` [PATCH net-next v5 1/4] net/sched: user-space can't set unknown tcfa_action values Paolo Abeni
2018-07-30 12:36   ` Jiri Pirko
2018-07-30 14:03   ` Jamal Hadi Salim
2018-07-30 14:21     ` Jiri Pirko
2018-07-30 16:41     ` Paolo Abeni
2018-07-30 19:31       ` Jamal Hadi Salim
2018-07-31  9:41         ` Paolo Abeni
2018-07-31 13:53           ` Jamal Hadi Salim
2018-07-31 14:40             ` Paolo Abeni
2018-08-01 14:34               ` Jamal Hadi Salim
2018-07-30 12:30 ` [PATCH net-next v5 2/4] tc/act: remove unneeded RCU lock in action callback Paolo Abeni
2018-07-30 12:30 ` [PATCH net-next v5 3/4] net/tc: introduce TC_ACT_REINSERT Paolo Abeni
2018-07-30 12:40   ` Jiri Pirko
2018-07-30 16:31     ` David Miller
2018-07-30 16:49       ` Jiri Pirko
2018-07-30 16:56         ` David Miller
2018-07-30 12:30 ` [PATCH net-next v5 4/4] act_mirred: use TC_ACT_REINSERT when possible Paolo Abeni
2018-07-30 12:42   ` Jiri Pirko
2018-07-30 16:31 ` [PATCH net-next v5 0/4] TC: refactor act_mirred packets re-injection David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1532934532.git.pabeni@redhat.com \
    --to=pabeni@redhat.com \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=eyal.birger@gmail.com \
    --cc=jhs@mojatatu.com \
    --cc=jiri@resnulli.us \
    --cc=marcelo.leitner@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).