netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Guillaume Nault <g.nault@alphalink.fr>
To: netdev@vger.kernel.org
Cc: James Chapman <jchapman@katalix.com>
Subject: [PATCH net-next 0/3] l2tp: sanitise MTU handling on sessions
Date: Fri, 3 Aug 2018 12:38:32 +0200	[thread overview]
Message-ID: <cover.1533289827.git.g.nault@alphalink.fr> (raw)

Most of the code handling sessions' MTU has no effect. The ->mtu field
in struct l2tp_session might be used at session creation time, but
neither PPP nor Ethernet pseudo-wires take updates into account.

L2TP sessions don't have a concept of MTU, which is the reason why
->mtu is mostly ignored. MTU should remain a network device thing.
Therefore this patch set does not try to propagate/update ->mtu to/from
the device. That would complicate the code unnecessarily. Instead this
field and the associated ioctl commands and netlink attributes are
removed.

Patch #1 defines l2tp_tunnel_dst_mtu() in order to simplify the
following patches. Then patches #2 and #3 remove MTU handling from PPP
and Ethernet pseudo-wires respectively.

Guillaume Nault (3):
  l2tp: define l2tp_tunnel_dst_mtu()
  l2tp: simplify MTU handling in l2tp_ppp
  l2tp: ignore L2TP_ATTR_MTU

 include/uapi/linux/l2tp.h |  2 +-
 net/l2tp/l2tp_core.c      |  1 -
 net/l2tp/l2tp_core.h      | 20 +++++++++--
 net/l2tp/l2tp_debugfs.c   |  3 +-
 net/l2tp/l2tp_eth.c       | 25 +++++--------
 net/l2tp/l2tp_netlink.c   |  9 +----
 net/l2tp/l2tp_ppp.c       | 74 ++++++++++-----------------------------
 7 files changed, 47 insertions(+), 87 deletions(-)

-- 
2.18.0

             reply	other threads:[~2018-08-03 12:34 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-03 10:38 Guillaume Nault [this message]
2018-08-03 10:38 ` [PATCH net-next 1/3] l2tp: define l2tp_tunnel_dst_mtu() Guillaume Nault
2018-08-03 10:38 ` [PATCH net-next 2/3] l2tp: simplify MTU handling in l2tp_ppp Guillaume Nault
2018-08-03 10:38 ` [PATCH net-next 3/3] l2tp: ignore L2TP_ATTR_MTU Guillaume Nault
2018-08-03 17:04 ` [PATCH net-next 0/3] l2tp: sanitise MTU handling on sessions David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1533289827.git.g.nault@alphalink.fr \
    --to=g.nault@alphalink.fr \
    --cc=jchapman@katalix.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).