netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Petr Machata <petrm@mellanox.com>
To: "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Cc: Jiri Pirko <jiri@mellanox.com>,
	Ido Schimmel <idosch@mellanox.com>,
	"davem@davemloft.net" <davem@davemloft.net>,
	"ivecera@redhat.com" <ivecera@redhat.com>
Subject: [PATCH net-next 0/9] Pass extack to SWITCHDEV_PORT_OBJ_ADD
Date: Wed, 12 Dec 2018 11:52:06 +0000	[thread overview]
Message-ID: <cover.1544614445.git.petrm@mellanox.com> (raw)

Drivers may need to do validation as a result of port object addition.
An example is mlxsw, which needs to check the configuration of a VXLAN
device attached to an offloaded bridge. Without a mapped VLAN, the
invalidity of the device is not important, but as soon as a pvid,
untagged VLAN is configured for the device, it has to be validated and
offloaded. Should the validation fail, there's currently no way to
communicate details of the failure to the user, beyond an error number.

Because currently, extack is not available at all in that area of code,
this patch starts down at the RTNL level and progresses up towards the
driver(s).

In patch #1, ndo_bridge_setlink is updated to include extack, and
callbacks of all clients are updated as well (ignoring the argument).

In patch #2, the bridge driver is updated to propagate the extack
through to the switchdev border, br_switchdev_port_vlan_add().

Patches #3, #4 and #5 then gradually extend switchdev to pass the extack
argument through to the switchdev blocking notifier chain.

Patches #6 and #7 then update mlxsw to pass the extack argument from
VXLAN events resp. port events on to mlxsw_sp_bridge_8021q_vxlan_join().

Finally in patches #8 and #9, the code paths from the previous two
patches are verified to yield an error message.

Petr Machata (9):
  net: ndo_bridge_setlink: Add extack
  net: bridge: Propagate extack to switchdev
  net: switchdev: Add extack argument to switchdev_port_obj_add()
  net: switchdev: Add extack to struct switchdev_notifier_info
  net: switchdev: Add extack to switchdev_handle_port_obj_add() callback
  mlxsw: spectrum_switchdev: Propagate extack on VXLAN VLAN events
  mlxsw: spectrum_switchdev: Propagate extack on port VLAN events
  selftests: mlxsw: extack: Test VLAN add on a VXLAN device
  selftests: mlxsw: extack: Test VLAN add on a port device

 drivers/net/ethernet/broadcom/bnxt/bnxt.c          |  2 +-
 drivers/net/ethernet/emulex/benet/be_main.c        |  2 +-
 drivers/net/ethernet/intel/i40e/i40e_main.c        |  4 +-
 drivers/net/ethernet/intel/ice/ice_main.c          |  3 +-
 drivers/net/ethernet/intel/ixgbe/ixgbe_main.c      |  3 +-
 .../ethernet/mellanox/mlxsw/spectrum_switchdev.c   | 53 ++++++++++++-------
 drivers/net/ethernet/mscc/ocelot.c                 |  3 +-
 drivers/net/vxlan.c                                |  1 +
 include/linux/netdevice.h                          |  6 ++-
 include/net/switchdev.h                            | 25 ++++++---
 net/bridge/br_if.c                                 |  2 +-
 net/bridge/br_mdb.c                                |  4 +-
 net/bridge/br_netlink.c                            | 30 ++++++-----
 net/bridge/br_private.h                            | 25 +++++----
 net/bridge/br_switchdev.c                          |  5 +-
 net/bridge/br_vlan.c                               | 59 ++++++++++++---------
 net/core/rtnetlink.c                               |  6 ++-
 net/switchdev/switchdev.c                          | 38 +++++++++-----
 .../testing/selftests/drivers/net/mlxsw/extack.sh  | 61 ++++++++++++++++++++++
 19 files changed, 230 insertions(+), 102 deletions(-)

-- 
2.4.11

             reply	other threads:[~2018-12-12 11:52 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-12 11:52 Petr Machata [this message]
2018-12-12 11:52 ` [PATCH net-next 1/9] net: ndo_bridge_setlink: Add extack Petr Machata
2018-12-12 12:26   ` Nikolay Aleksandrov
2018-12-12 13:58     ` Petr Machata
2018-12-12 11:52 ` [PATCH net-next 2/9] net: bridge: Propagate extack to switchdev Petr Machata
2018-12-12 12:20   ` Nikolay Aleksandrov
2018-12-12 13:05   ` Ivan Vecera
2018-12-12 15:33   ` Roopa Prabhu
2018-12-12 11:52 ` [PATCH net-next 3/9] net: switchdev: Add extack argument to switchdev_port_obj_add() Petr Machata
2018-12-12 13:11   ` Ivan Vecera
2018-12-12 11:52 ` [PATCH net-next 4/9] net: switchdev: Add extack to struct switchdev_notifier_info Petr Machata
2018-12-12 13:12   ` Ivan Vecera
2018-12-12 11:52 ` [PATCH net-next 5/9] net: switchdev: Add extack to switchdev_handle_port_obj_add() callback Petr Machata
2018-12-12 13:12   ` Ivan Vecera
2018-12-12 11:52 ` [PATCH net-next 6/9] mlxsw: spectrum_switchdev: Propagate extack on VXLAN VLAN events Petr Machata
2018-12-12 11:52 ` [PATCH net-next 7/9] mlxsw: spectrum_switchdev: Propagate extack on port " Petr Machata
2018-12-12 11:52 ` [PATCH net-next 8/9] selftests: mlxsw: extack: Test VLAN add on a VXLAN device Petr Machata
2018-12-12 11:52 ` [PATCH net-next 9/9] selftests: mlxsw: extack: Test VLAN add on a port device Petr Machata

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1544614445.git.petrm@mellanox.com \
    --to=petrm@mellanox.com \
    --cc=davem@davemloft.net \
    --cc=idosch@mellanox.com \
    --cc=ivecera@redhat.com \
    --cc=jiri@mellanox.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).