From: Petr Machata <petrm@mellanox.com>
To: "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Cc: "davem@davemloft.net" <davem@davemloft.net>,
Ido Schimmel <idosch@mellanox.com>,
"roopa@cumulusnetworks.com" <roopa@cumulusnetworks.com>
Subject: [PATCH net v2 0/4] vxlan: Various fixes
Date: Mon, 17 Dec 2018 18:09:57 +0000 [thread overview]
Message-ID: <cover.1545068986.git.petrm@mellanox.com> (raw)
This patch set contains three fixes for the vxlan driver.
Patch #1 fixes handling of offload mark on replaced VXLAN FDB entries. A
way to trigger this is to replace the FDB entry with one that can not be
offloaded. A future patch set should make it possible to veto such FDB
changes. However the FDB might still fail to be offloaded due to another
issue, and the offload mark should reflect that.
Patch #2 fixes problems in __vxlan_dev_create() when a call to
rtnl_configure_link() fails. These failures would be tricky to hit on a
real system, the most likely vector is through an error in vxlan_open().
However, with the abovementioned vetoing patchset, vetoing the created
entry would trigger the same problems (and be easier to reproduce).
Patch #3 fixes a problem in vxlan_changelink(). In situations where the
default remote configured in the FDB table (if any) does not exactly
match the remote address configured at the VXLAN device, changing the
remote address breaks the default FDB entry. Patch #4 is then a self
test for this issue.
v2:
- Drop former patch #3
- Patch #2:
- Delete the default entry before calling unregister_netdevice(). That
takes care of former patch #3, hence tweak the commit message to
mention that problem as well.
Petr Machata (4):
vxlan: Unmark offloaded bit on replaced FDB entries
vxlan: Fix error path in __vxlan_dev_create()
vxlan: changelink: Fix handling of default remotes
selftests: net: Add test_vxlan_fdb_changelink.sh
drivers/net/vxlan.c | 25 ++++++++++++-------
tools/testing/selftests/net/Makefile | 1 +
.../selftests/net/test_vxlan_fdb_changelink.sh | 29 ++++++++++++++++++++++
3 files changed, 46 insertions(+), 9 deletions(-)
create mode 100755 tools/testing/selftests/net/test_vxlan_fdb_changelink.sh
--
2.4.11
next reply other threads:[~2018-12-17 18:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-17 18:09 Petr Machata [this message]
2018-12-17 18:09 ` [PATCH net v2 1/4] vxlan: Unmark offloaded bit on replaced FDB entries Petr Machata
2018-12-17 18:10 ` [PATCH net v2 2/4] vxlan: Fix error path in __vxlan_dev_create() Petr Machata
2018-12-17 20:07 ` Roopa Prabhu
2018-12-17 23:41 ` Petr Machata
2018-12-17 18:10 ` [PATCH net v2 3/4] vxlan: changelink: Fix handling of default remotes Petr Machata
2018-12-17 19:59 ` Roopa Prabhu
2018-12-17 23:44 ` Petr Machata
2018-12-18 1:30 ` Roopa Prabhu
2018-12-18 11:20 ` Petr Machata
2018-12-17 18:10 ` [PATCH net v2 4/4] selftests: net: Add test_vxlan_fdb_changelink.sh Petr Machata
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1545068986.git.petrm@mellanox.com \
--to=petrm@mellanox.com \
--cc=davem@davemloft.net \
--cc=idosch@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=roopa@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).