From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00D5FC43381 for ; Wed, 27 Feb 2019 12:10:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B79142075B for ; Wed, 27 Feb 2019 12:10:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=AQUANTIA1COM.onmicrosoft.com header.i=@AQUANTIA1COM.onmicrosoft.com header.b="YNP8nA0X" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729964AbfB0MKF (ORCPT ); Wed, 27 Feb 2019 07:10:05 -0500 Received: from mail-eopbgr750051.outbound.protection.outlook.com ([40.107.75.51]:28496 "EHLO NAM02-BL2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729822AbfB0MKE (ORCPT ); Wed, 27 Feb 2019 07:10:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=AQUANTIA1COM.onmicrosoft.com; s=selector1-aquantia-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sCvXb/FbGyG6oep+daYn40j4WUNI2+mPOyTjAyO785I=; b=YNP8nA0XShGWz8YCzOcY/exX825ZBiim85XU1SDmxo7B0hdo5XEHfGEMkHe+6sHRYrcAVzRK2dZ4Gi+KBB9KrNhQb7FN86yiMmu0DWmWOxgdieNxt2zWKrYmCHkf+PSWxrJDEKeedZK6QohYwa9FuBWKiUVTyhMES+qOQyJJeO0= Received: from DM6PR11MB3625.namprd11.prod.outlook.com (20.178.230.149) by DM6PR11MB4009.namprd11.prod.outlook.com (20.176.125.78) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1665.15; Wed, 27 Feb 2019 12:10:01 +0000 Received: from DM6PR11MB3625.namprd11.prod.outlook.com ([fe80::319e:4e9b:b376:5588]) by DM6PR11MB3625.namprd11.prod.outlook.com ([fe80::319e:4e9b:b376:5588%4]) with mapi id 15.20.1643.019; Wed, 27 Feb 2019 12:10:01 +0000 From: Igor Russkikh To: "David S . Miller" CC: "netdev@vger.kernel.org" , Igor Russkikh Subject: [PATCH v2 net-next 0/6] net: aquantia: minor bug fixes after static analysis Thread-Topic: [PATCH v2 net-next 0/6] net: aquantia: minor bug fixes after static analysis Thread-Index: AQHUzpVdZ6OscUBOMEWuiulrKX4ewQ== Date: Wed, 27 Feb 2019 12:10:01 +0000 Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: BYAPR01CA0032.prod.exchangelabs.com (2603:10b6:a02:80::45) To DM6PR11MB3625.namprd11.prod.outlook.com (2603:10b6:5:13a::21) authentication-results: spf=none (sender IP is ) smtp.mailfrom=Igor.Russkikh@aquantia.com; x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.17.1 x-originating-ip: [95.79.108.179] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f80b7f32-07f0-4775-578c-08d69cac7f8c x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(2017052603328)(7153060)(7193020);SRVR:DM6PR11MB4009; x-ms-traffictypediagnostic: DM6PR11MB4009: x-microsoft-exchange-diagnostics: =?iso-8859-1?Q?1;DM6PR11MB4009;23:+W6aMYMS5O5fmXZUoBCTyf7ZwOf3p8yeayYMDbC?= =?iso-8859-1?Q?ELjBMdV4YoYiUk0vg+ftRPqCzCta6XfBfjFeJsTHXqD8Tp12vx0sQQPSsA?= =?iso-8859-1?Q?7nWLeYQ0kdKzaoMAF+rLX3rdnS59IU2vbYmR0Uc6UyOdiIpVO1/lT9aglp?= =?iso-8859-1?Q?f0KhbbrgTGDKOp2mf6icXs+Z3mfEbmS21Dae0hYSyDvT+tAH+1l8kUbdxr?= =?iso-8859-1?Q?Uvq+2OYp7FQPuDOW7M1YmjYRmZAPkZ0yVkJVe04MTlFTsRsv1pYcfRdgEY?= =?iso-8859-1?Q?SzDXkRUpj+sodjqGd4xVz1f1fOyU1gvDzYZ4LR5RylWYoDne+R7csGwZnL?= =?iso-8859-1?Q?E/QZj8EQhRvzJJl2gEJdaSOLHpih0kfaAIab25flb3U6MbWDMliHzHIWA+?= =?iso-8859-1?Q?LeRmgAYiZJeeTTrU/y3DKWtidckJ6FoKre91j1Jf1vrbOXbWqz6K/DWCrh?= =?iso-8859-1?Q?24leoIuAz71+bCLsm3Qw37JfQRiVQTva/1Rw/eEgAfWkURofUEDyQChfle?= =?iso-8859-1?Q?eSctQWDjA7OMLAC6GR2d/eJezBYPXBchM2dU9q7ZfAgyFQ0oHVHL8Jg95A?= =?iso-8859-1?Q?HnU3p4aR0UMwG6cuxU7Xj9ui1amhN6N2MV0PxQ7Ajhs2F8UXFk46ETMTqj?= =?iso-8859-1?Q?lTkpOGgA4TmyTA364nQ4lqSKPZZdZ8tsLSL6xoe442ceiM32BR2LQvqGWM?= =?iso-8859-1?Q?WSsF6qy0MzrlKwVqskjKXy441e3D6S9TuNIcY33w3nWwZJp2aMB2FIP1yU?= =?iso-8859-1?Q?SFviTSZNsLK8oKW3AuqjSNFGo5+RlwCBAObbM3X1ZfJ91E/9vjFLT67oNe?= =?iso-8859-1?Q?SI2xCvaU5Bq3+1tvbLBZfsRDarNGSy407KNUGn8rrq+qJKV+3+fT/ivo6E?= =?iso-8859-1?Q?Mw8evm58FvSpIq4iS94JpfOWKfPsj91JFsJ+/S3Y+Bz2N1eC0UExMRV/vt?= =?iso-8859-1?Q?7kg/KZuu5coPJt32xDbOFw+Pqcxys0Spz/zZ7bsPE8cDV9qMliaDo2vYF0?= =?iso-8859-1?Q?R2Ledqh7UNDxedk+GtpgE+FjAnctO2zGyM53mRMNcbGMdFqaUcmKnmWiX5?= =?iso-8859-1?Q?MGkXcPPGVdLi/Xrk1TucBU9aUbRU929DDMl8bsFvk09mE3udnfbR5lYVaW?= =?iso-8859-1?Q?uaAn2osxtqrlTCL2L5FuMimjDOfCSAcMgp/d6nEO4VV9JCXYJW+ySZ3h4A?= =?iso-8859-1?Q?xmIQTE61r3WrXVxHU8mBA9GN60HB25hLD+OWPZbusqP+WrFwH40P6T3Cuz?= =?iso-8859-1?Q?KaJO5O9JQx1sA1Mf+f8b9S4UlfcHeAp2jjkloOYTZi0aNYE8XyS6pvPb8K?= =?iso-8859-1?Q?RJBH9m5+USZM1qTatJhE9oi+3ZvHWFtwFTshCYqEr7Q+Q=3D=3D?= x-microsoft-antispam-prvs: x-forefront-prvs: 0961DF5286 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(979002)(136003)(396003)(39850400004)(346002)(376002)(366004)(189003)(199004)(25786009)(2616005)(316002)(54906003)(2906002)(476003)(44832011)(66066001)(6916009)(478600001)(102836004)(53936002)(486006)(105586002)(72206003)(106356001)(6512007)(4326008)(71190400001)(71200400001)(107886003)(81156014)(81166006)(52116002)(305945005)(7736002)(5660300002)(99286004)(6116002)(3846002)(8936002)(50226002)(68736007)(186003)(6506007)(386003)(86362001)(256004)(14454004)(6486002)(26005)(6436002)(8676002)(36756003)(97736004)(969003)(989001)(999001)(1009001)(1019001);DIR:OUT;SFP:1101;SCL:1;SRVR:DM6PR11MB4009;H:DM6PR11MB3625.namprd11.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: aquantia.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: kVtmIr5GwkFUPmdikmw7SgirX65XvFsAzBEsTIR2CsCgzaGHNLaowg2kGvGvMK/LR29WXivXBgPykWseOtjViFdgzq8jxbWlHGyatveDiknih8ipKBNSHTE3tn3SNOP5Saq5rCAoJmtuv+gVkU5WULeddNO/2FFFyMSaPBuWxZwuI4T2XjCgKVM5XRM5i5Zvzdols36860lCde0548m5vIxzMWvgJQGR/IfWtQtAdN5dbINoP6L90fioQs+IN256ZxBCLGu/eeerYBF6lkmImq1ez/UqWlRgWXVZGDrt5JmfAWPib9JKt2oHAMhFEmaELcicH0JMiTclRm+L0H1S44cvMHedbwfDVAzohZussyQ4BU8AdDQdnyXxWh2pQjI6ZQ+DPoHkrDHHJyrUEBcpxmFGUUZ2D57Hj6apa6w1nFQ= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: aquantia.com X-MS-Exchange-CrossTenant-Network-Message-Id: f80b7f32-07f0-4775-578c-08d69cac7f8c X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Feb 2019 12:09:59.5907 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-id: 83e2e134-991c-4ede-8ced-34d47e38e6b1 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4009 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This patchset fixes minor errors and warnings found by smatch and kasan. Extra patch is to replace AQ_HW_WAIT_FOR with readx_poll_timeout to improve readability. V2: use readx_poll resubmitted to net-next since the changeset became quite big. Igor Russkikh (1): net: aquantia: fixed instack structure overflow Nikita Danilov (5): net: aquantia: fixed memcpy size net: aquantia: added newline at end of file net: aquantia: fixed buffer overflow net: aquantia: replace AQ_HW_WAIT_FOR with readx_poll_timeout_atomic net: aquantia: use better wrappers for state registers .../ethernet/aquantia/atlantic/aq_ethtool.c | 2 +- .../ethernet/aquantia/atlantic/aq_hw_utils.h | 14 +-- .../net/ethernet/aquantia/atlantic/aq_nic.c | 2 +- .../ethernet/aquantia/atlantic/aq_pci_func.c | 2 + .../aquantia/atlantic/hw_atl/hw_atl_a0.c | 25 ++-- .../aquantia/atlantic/hw_atl/hw_atl_b0.c | 16 ++- .../aquantia/atlantic/hw_atl/hw_atl_llh.c | 21 ++++ .../aquantia/atlantic/hw_atl/hw_atl_llh.h | 12 ++ .../atlantic/hw_atl/hw_atl_llh_internal.h | 2 + .../aquantia/atlantic/hw_atl/hw_atl_utils.c | 116 ++++++++++++------ .../atlantic/hw_atl/hw_atl_utils_fw2x.c | 68 +++++++--- 11 files changed, 197 insertions(+), 83 deletions(-) --=20 2.17.1