netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Abeni <pabeni@redhat.com>
To: netdev@vger.kernel.org
Cc: Mike Marciniszyn <mike.marciniszyn@intel.com>,
	Doug Ledford <dledford@redhat.com>,
	Jay Vosburgh <j.vosburgh@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	Saeed Bishara <saeedb@amazon.com>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Ariel Elior <aelior@marvell.com>,
	Vishal Kulkarni <vishal@chelsio.com>,
	Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
	Salil Mehta <salil.mehta@huawei.com>,
	Tariq Toukan <tariqt@mellanox.com>,
	"K. Y. Srinivasan" <kys@microsoft.com>,
	Kalle Valo <kvalo@codeaurora.org>, Wei Liu <wei.liu2@citrix.com>,
	Johannes Berg <johannes@sipsolutions.net>,
	Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Subject: [PATCH net-next 0/2] net: refactor ndo_select_queue()
Date: Tue, 19 Mar 2019 14:25:00 +0100	[thread overview]
Message-ID: <cover.1552497037.git.pabeni@redhat.com> (raw)

Currently, on most devices implementing ndo_select_queue(), we get 2
indirect calls per xmit packet, at least in some scenarios.

We can avoid one of such indirect calls refactoring the ndo_select_queue()
usage so that we don't need anymore the 'fallback' argument.

The first patch changes the af packet implementation so that it uses the common
infrastructure to select the xmit queue, and the second patch drops the now
unneeded argument from ndo_select_queue()

Alternatively we could use the INDIRECT_CALL_WRAPPER infrastructure to avoid
the fallback indirect call in the common case, but this solution allow also
for some code cleanup.

Paolo Abeni (2):
  packet: rework packet_pick_tx_queue() to use common code selection
  net: remove 'fallback' argument from dev->ndo_select_queue()

 drivers/infiniband/hw/hfi1/vnic_main.c           |  3 +--
 .../infiniband/ulp/opa_vnic/opa_vnic_netdev.c    |  6 ++----
 drivers/net/bonding/bond_main.c                  |  3 +--
 drivers/net/ethernet/amazon/ena/ena_netdev.c     |  5 ++---
 drivers/net/ethernet/broadcom/bcmsysport.c       |  7 +++----
 drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c  |  5 ++---
 drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.h  |  3 +--
 drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c  |  5 ++---
 drivers/net/ethernet/hisilicon/hns/hns_enet.c    |  5 ++---
 drivers/net/ethernet/intel/ixgbe/ixgbe_main.c    |  5 ++---
 drivers/net/ethernet/mellanox/mlx4/en_tx.c       |  7 +++----
 drivers/net/ethernet/mellanox/mlx4/mlx4_en.h     |  3 +--
 drivers/net/ethernet/mellanox/mlx5/core/en.h     |  3 +--
 drivers/net/ethernet/mellanox/mlx5/core/en_tx.c  |  5 ++---
 drivers/net/ethernet/qlogic/qede/qede.h          |  3 +--
 drivers/net/ethernet/qlogic/qede/qede_fp.c       |  5 ++---
 drivers/net/ethernet/renesas/ravb_main.c         |  3 +--
 drivers/net/ethernet/sun/ldmvsw.c                |  3 +--
 drivers/net/ethernet/sun/sunvnet.c               |  3 +--
 drivers/net/hyperv/netvsc_drv.c                  |  8 +++-----
 drivers/net/net_failover.c                       |  8 +++-----
 drivers/net/team/team.c                          |  3 +--
 drivers/net/tun.c                                |  3 +--
 drivers/net/wireless/marvell/mwifiex/main.c      |  3 +--
 drivers/net/xen-netback/interface.c              |  6 +++---
 drivers/net/xen-netfront.c                       |  3 +--
 drivers/staging/rtl8188eu/os_dep/os_intfs.c      |  3 +--
 drivers/staging/rtl8723bs/os_dep/os_intfs.c      |  3 +--
 include/linux/netdevice.h                        | 14 ++++++--------
 net/core/dev.c                                   | 14 ++++++--------
 net/mac80211/iface.c                             |  6 ++----
 net/packet/af_packet.c                           | 16 +++++++---------
 32 files changed, 67 insertions(+), 105 deletions(-)

-- 
2.20.1


             reply	other threads:[~2019-03-19 13:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-19 13:25 Paolo Abeni [this message]
2019-03-19 13:25 ` [PATCH net-next 1/2] packet: rework packet_pick_tx_queue() to use common code selection Paolo Abeni
2019-03-19 13:54   ` Eric Dumazet
2019-03-19 21:06   ` David Miller
2019-03-19 13:25 ` [PATCH net-next 2/2] net: remove 'fallback' argument from dev->ndo_select_queue() Paolo Abeni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1552497037.git.pabeni@redhat.com \
    --to=pabeni@redhat.com \
    --cc=aelior@marvell.com \
    --cc=davem@davemloft.net \
    --cc=dledford@redhat.com \
    --cc=f.fainelli@gmail.com \
    --cc=j.vosburgh@gmail.com \
    --cc=jeffrey.t.kirsher@intel.com \
    --cc=johannes@sipsolutions.net \
    --cc=kvalo@codeaurora.org \
    --cc=kys@microsoft.com \
    --cc=mike.marciniszyn@intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=saeedb@amazon.com \
    --cc=salil.mehta@huawei.com \
    --cc=tariqt@mellanox.com \
    --cc=vishal@chelsio.com \
    --cc=wei.liu2@citrix.com \
    --cc=willemdebruijn.kernel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).