From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE4B0C43381 for ; Tue, 19 Mar 2019 13:25:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8476820854 for ; Tue, 19 Mar 2019 13:25:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726717AbfCSNZn (ORCPT ); Tue, 19 Mar 2019 09:25:43 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34384 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725951AbfCSNZn (ORCPT ); Tue, 19 Mar 2019 09:25:43 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5CC1DE6A68; Tue, 19 Mar 2019 13:25:42 +0000 (UTC) Received: from localhost.localdomain.com (unknown [10.32.181.117]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5D0282899E; Tue, 19 Mar 2019 13:25:18 +0000 (UTC) From: Paolo Abeni To: netdev@vger.kernel.org Cc: Mike Marciniszyn , Doug Ledford , Jay Vosburgh , "David S. Miller" , Saeed Bishara , Florian Fainelli , Ariel Elior , Vishal Kulkarni , Jeff Kirsher , Salil Mehta , Tariq Toukan , "K. Y. Srinivasan" , Kalle Valo , Wei Liu , Johannes Berg , Willem de Bruijn Subject: [PATCH net-next 0/2] net: refactor ndo_select_queue() Date: Tue, 19 Mar 2019 14:25:00 +0100 Message-Id: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Tue, 19 Mar 2019 13:25:42 +0000 (UTC) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Currently, on most devices implementing ndo_select_queue(), we get 2 indirect calls per xmit packet, at least in some scenarios. We can avoid one of such indirect calls refactoring the ndo_select_queue() usage so that we don't need anymore the 'fallback' argument. The first patch changes the af packet implementation so that it uses the common infrastructure to select the xmit queue, and the second patch drops the now unneeded argument from ndo_select_queue() Alternatively we could use the INDIRECT_CALL_WRAPPER infrastructure to avoid the fallback indirect call in the common case, but this solution allow also for some code cleanup. Paolo Abeni (2): packet: rework packet_pick_tx_queue() to use common code selection net: remove 'fallback' argument from dev->ndo_select_queue() drivers/infiniband/hw/hfi1/vnic_main.c | 3 +-- .../infiniband/ulp/opa_vnic/opa_vnic_netdev.c | 6 ++---- drivers/net/bonding/bond_main.c | 3 +-- drivers/net/ethernet/amazon/ena/ena_netdev.c | 5 ++--- drivers/net/ethernet/broadcom/bcmsysport.c | 7 +++---- drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c | 5 ++--- drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.h | 3 +-- drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 5 ++--- drivers/net/ethernet/hisilicon/hns/hns_enet.c | 5 ++--- drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 5 ++--- drivers/net/ethernet/mellanox/mlx4/en_tx.c | 7 +++---- drivers/net/ethernet/mellanox/mlx4/mlx4_en.h | 3 +-- drivers/net/ethernet/mellanox/mlx5/core/en.h | 3 +-- drivers/net/ethernet/mellanox/mlx5/core/en_tx.c | 5 ++--- drivers/net/ethernet/qlogic/qede/qede.h | 3 +-- drivers/net/ethernet/qlogic/qede/qede_fp.c | 5 ++--- drivers/net/ethernet/renesas/ravb_main.c | 3 +-- drivers/net/ethernet/sun/ldmvsw.c | 3 +-- drivers/net/ethernet/sun/sunvnet.c | 3 +-- drivers/net/hyperv/netvsc_drv.c | 8 +++----- drivers/net/net_failover.c | 8 +++----- drivers/net/team/team.c | 3 +-- drivers/net/tun.c | 3 +-- drivers/net/wireless/marvell/mwifiex/main.c | 3 +-- drivers/net/xen-netback/interface.c | 6 +++--- drivers/net/xen-netfront.c | 3 +-- drivers/staging/rtl8188eu/os_dep/os_intfs.c | 3 +-- drivers/staging/rtl8723bs/os_dep/os_intfs.c | 3 +-- include/linux/netdevice.h | 14 ++++++-------- net/core/dev.c | 14 ++++++-------- net/mac80211/iface.c | 6 ++---- net/packet/af_packet.c | 16 +++++++--------- 32 files changed, 67 insertions(+), 105 deletions(-) -- 2.20.1