netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Abeni <pabeni@redhat.com>
To: netdev@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	John Fastabend <john.fastabend@gmail.com>,
	Ivan Vecera <ivecera@redhat.com>
Subject: [PATCH net-next 0/2] net: dev: BYPASS for lockless qdisc
Date: Thu, 21 Mar 2019 11:14:17 +0100	[thread overview]
Message-ID: <cover.1553118918.git.pabeni@redhat.com> (raw)

This patch series is aimed at improving xmit performances of lockless qdisc
in the uncontended scenario.

After the lockless refactor pfifo_fast can't leverage the BYPASS optimization.
Due to retpolines the overhead for the avoidables enqueue and dequeue operations
has increased and we see measurable regressions.

The first patch introduces and maintains an additional flag inside the qdisc
struct, tracking the queue status (empty/not empty) and the second patch uses
such info to implement the BYPASS code path for lockless qdisc.
Overall this avoids up to 2 indirect calls per xmit packet when the packet
rate is below line rate.
Detailed performance figures are reported in the 2nd patch.

Paolo Abeni (2):
  net: sched: add empty status flag for NOLOCK qdisc
  net: dev: introduce support for sch BYPASS for lockless qdisc

 include/net/sch_generic.h | 17 +++++++++++++++++
 net/core/dev.c            |  9 +++++++++
 net/sched/sch_generic.c   |  2 ++
 3 files changed, 28 insertions(+)

-- 
2.20.1


             reply	other threads:[~2019-03-21 10:14 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-21 10:14 Paolo Abeni [this message]
2019-03-21 10:14 ` [PATCH net-next 1/2] net: sched: add empty status flag for NOLOCK qdisc Paolo Abeni
2019-03-21 14:42   ` Eric Dumazet
2019-03-21 15:10     ` Paolo Abeni
2019-03-21 10:14 ` [PATCH net-next 2/2] net: dev: introduce support for sch BYPASS for lockless qdisc Paolo Abeni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1553118918.git.pabeni@redhat.com \
    --to=pabeni@redhat.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=ivecera@redhat.com \
    --cc=john.fastabend@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).