From: Josh Poimboeuf <jpoimboe@redhat.com>
To: x86@kernel.org
Cc: linux-kernel@vger.kernel.org, Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
netdev@vger.kernel.org, bpf@vger.kernel.org,
Peter Zijlstra <peterz@infradead.org>,
Song Liu <songliubraving@fb.com>, Kairui Song <kasong@redhat.com>
Subject: [PATCH 0/9] x86/bpf: unwinder fixes
Date: Thu, 13 Jun 2019 08:20:57 -0500 [thread overview]
Message-ID: <cover.1560431531.git.jpoimboe@redhat.com> (raw)
The following commit
d15d356887e7 ("perf/x86: Make perf callchains work without CONFIG_FRAME_POINTER")
was a step in the right direction, but it triggered some BPF selftest
failures. That commit exposed the fact that we currently can't unwind
through BPF code.
- Patch 1 (originally from Song Liu) fixes a bug in the above commit
(regs->ip getting skipped in the stack trace).
- Patch 2 fixes non-JIT BPF for the ORC unwinder.
- Patches 3-5 are preparatory improvements for patch 6.
- Patch 6 fixes JIT BPF for the FP unwinder.
- Patch 7 fixes JIT BPF for the ORC unwinder (building on patch 6).
- Patches 8-9 are some readability cleanups.
Josh Poimboeuf (8):
objtool: Fix ORC unwinding in non-JIT BPF generated code
x86/bpf: Move epilogue generation to a dedicated function
x86/bpf: Simplify prologue generation
x86/bpf: Support SIB byte generation
x86/bpf: Fix JIT frame pointer usage
x86/unwind/orc: Fall back to using frame pointers for generated code
x86/bpf: Convert asm comments to AT&T syntax
x86/bpf: Convert MOV function/macro argument ordering to AT&T syntax
Song Liu (1):
perf/x86: Always store regs->ip in perf_callchain_kernel()
arch/x86/events/core.c | 10 +-
arch/x86/kernel/unwind_orc.c | 26 ++-
arch/x86/net/bpf_jit_comp.c | 355 ++++++++++++++++++++---------------
kernel/bpf/core.c | 5 +-
tools/objtool/check.c | 16 +-
5 files changed, 246 insertions(+), 166 deletions(-)
--
2.20.1
next reply other threads:[~2019-06-13 15:16 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-13 13:20 Josh Poimboeuf [this message]
2019-06-13 13:20 ` [PATCH 1/9] perf/x86: Always store regs->ip in perf_callchain_kernel() Josh Poimboeuf
2019-06-13 13:20 ` [PATCH 2/9] objtool: Fix ORC unwinding in non-JIT BPF generated code Josh Poimboeuf
2019-06-13 20:57 ` Alexei Starovoitov
2019-06-14 1:20 ` Josh Poimboeuf
2019-06-14 1:37 ` Alexei Starovoitov
2019-06-14 1:51 ` Josh Poimboeuf
2019-06-14 7:08 ` Peter Zijlstra
2019-06-14 7:35 ` Alexei Starovoitov
2019-06-14 8:11 ` Peter Zijlstra
2019-06-14 15:13 ` Alexei Starovoitov
2019-06-14 16:11 ` Josh Poimboeuf
2019-06-13 13:21 ` [PATCH 3/9] x86/bpf: Move epilogue generation to a dedicated function Josh Poimboeuf
2019-06-13 18:57 ` Song Liu
2019-06-13 19:12 ` Josh Poimboeuf
2019-06-13 13:21 ` [PATCH 4/9] x86/bpf: Simplify prologue generation Josh Poimboeuf
2019-06-13 13:21 ` [PATCH 5/9] x86/bpf: Support SIB byte generation Josh Poimboeuf
2019-06-13 13:21 ` [PATCH 6/9] x86/bpf: Fix JIT frame pointer usage Josh Poimboeuf
2019-06-13 21:58 ` Alexei Starovoitov
2019-06-14 1:22 ` Josh Poimboeuf
2019-06-14 1:39 ` Alexei Starovoitov
2019-06-14 1:52 ` Josh Poimboeuf
2019-06-14 10:50 ` David Laight
2019-06-14 13:44 ` Josh Poimboeuf
2019-06-14 13:58 ` David Laight
2019-06-14 17:07 ` Josh Poimboeuf
2019-06-17 15:07 ` David Laight
2019-06-13 13:21 ` [PATCH 7/9] x86/unwind/orc: Fall back to using frame pointers for generated code Josh Poimboeuf
2019-06-13 22:00 ` Alexei Starovoitov
2019-06-14 1:30 ` Josh Poimboeuf
2019-06-14 1:42 ` Alexei Starovoitov
2019-06-14 1:58 ` Josh Poimboeuf
2019-06-14 2:28 ` Josh Poimboeuf
2019-06-14 4:50 ` Josh Poimboeuf
2019-06-14 6:00 ` Alexei Starovoitov
2019-06-14 7:41 ` Peter Zijlstra
2019-06-14 13:31 ` Josh Poimboeuf
2019-06-14 15:29 ` Alexei Starovoitov
2019-06-14 13:34 ` Josh Poimboeuf
2019-06-14 15:31 ` Alexei Starovoitov
2019-06-14 15:56 ` Josh Poimboeuf
2019-06-13 13:21 ` [PATCH 8/9] x86/bpf: Convert asm comments to AT&T syntax Josh Poimboeuf
2019-06-13 18:52 ` Song Liu
2019-06-13 19:11 ` Josh Poimboeuf
2019-06-14 7:42 ` Peter Zijlstra
2019-06-14 15:13 ` Song Liu
2019-06-13 13:21 ` [PATCH 9/9] x86/bpf: Convert MOV function/macro argument ordering " Josh Poimboeuf
2019-06-13 19:00 ` [PATCH 0/9] x86/bpf: unwinder fixes Song Liu
2019-06-13 20:41 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1560431531.git.jpoimboe@redhat.com \
--to=jpoimboe@redhat.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kasong@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=songliubraving@fb.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).