From: Davide Caratti <dcaratti@redhat.com>
To: borisp@mellanox.com, jakub.kicinski@netronome.com,
Eric Dumazet <eric.dumazet@gmail.com>
Cc: aviadye@mellanox.com, davejwatson@fb.com, davem@davemloft.net,
john.fastabend@gmail.com,
Matthieu Baerts <matthieu.baerts@tessares.net>,
netdev@vger.kernel.org
Subject: [PATCH net-next v2 0/3] net: tls: add socket diag
Date: Thu, 29 Aug 2019 18:48:01 +0200 [thread overview]
Message-ID: <cover.1567095873.git.dcaratti@redhat.com> (raw)
The current kernel does not provide any diagnostic tool, except
getsockopt(TCP_ULP), to know more about TCP sockets that have an upper
layer protocol (ULP) on top of them. This series extends the set of
information exported by INET_DIAG_INFO, to include data that are
specific to the ULP (and that might be meaningful for debug/testing
purposes).
patch 1/3 ensures that the control plane reads/updates ULP specific data
using RCU.
patch 2/3 extends INET_DIAG_INFO and allows knowing the ULP name for
each TCP socket that has done setsockopt(TCP_ULP) successfully.
patch 3/3 extends kTLS to let programs like 'ss' know the protocol
version and the cipher in use.
Changes since v1:
- don't worry about grace period when accessing ulp_ops, thanks to
Jakub Kicinski and Eric Dumazet
- use rcu_dereference() to access ULP data in tls get_info(), and
test against NULL value, thanks to Jakub Kicinski
- move RCU protected section inside tls get_info(), thanks to Jakub
Kicinski
Changes since RFC:
- some coding style fixes, thanks to Jakub Kicinski
- add X_UNSPEC as lowest value of uAPI enums, thanks to Jakub Kicinski
- fix assignment of struct nlattr *start, thanks to Jakub Kicinski
- let tls dump RXCONF and TXCONF, suggested by Jakub Kicinski
- don't dump anything if TLS version or cipher are 0 (but still return a
constant size in get_aux_size()), thanks to Boris Pismenny
- constify first argument of get_info() and get_size()
- use RCU to access access ulp_ops, like it's done for ca_ops
- add patch 1/3, from Jakub Kicinski
Davide Caratti (2):
tcp: ulp: add functions to dump ulp-specific information
net: tls: export protocol version, cipher, tx_conf/rx_conf to socket
diag
Jakub Kicinski (1):
net/tls: use RCU protection on icsk->icsk_ulp_data
include/net/inet_connection_sock.h | 2 +-
include/net/tcp.h | 3 +
include/net/tls.h | 28 +++++++++-
include/uapi/linux/inet_diag.h | 9 +++
include/uapi/linux/tls.h | 15 +++++
net/core/sock_map.c | 2 +-
net/ipv4/tcp_diag.c | 52 ++++++++++++++++-
net/tls/tls_device.c | 2 +-
net/tls/tls_main.c | 90 +++++++++++++++++++++++++++---
9 files changed, 190 insertions(+), 13 deletions(-)
--
2.20.1
next reply other threads:[~2019-08-29 16:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-29 16:48 Davide Caratti [this message]
2019-08-29 16:48 ` [PATCH net-next v2 1/3] net/tls: use RCU protection on icsk->icsk_ulp_data Davide Caratti
2019-08-29 16:48 ` [PATCH net-next v2 2/3] tcp: ulp: add functions to dump ulp-specific information Davide Caratti
2019-08-29 16:48 ` [PATCH net-next v2 3/3] net: tls: export protocol version, cipher, tx_conf/rx_conf to socket diag Davide Caratti
2019-08-29 21:56 ` Jakub Kicinski
2019-08-30 8:56 ` Davide Caratti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1567095873.git.dcaratti@redhat.com \
--to=dcaratti@redhat.com \
--cc=aviadye@mellanox.com \
--cc=borisp@mellanox.com \
--cc=davejwatson@fb.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=jakub.kicinski@netronome.com \
--cc=john.fastabend@gmail.com \
--cc=matthieu.baerts@tessares.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).