netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Petr Machata <petrm@mellanox.com>
To: "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Cc: Jiri Pirko <jiri@mellanox.com>, Petr Machata <petrm@mellanox.com>
Subject: [PATCH net 0/2] When ungrafting from PRIO, replace child with FIFO
Date: Mon, 6 Jan 2020 18:01:53 +0000	[thread overview]
Message-ID: <cover.1578333529.git.petrm@mellanox.com> (raw)

When a child Qdisc is removed from one of the PRIO Qdisc's bands, it is
replaced unconditionally by a NOOP qdisc. As a result, any traffic hitting
that band gets dropped. That is incorrect--no Qdisc was explicitly added
when PRIO was created, and after removal, none should have to be added
either.

In patch #2, this problem is fixed for PRIO by first attempting to create a
default Qdisc and only falling back to noop when that fails. This pattern
of attempting to create an invisible FIFO, using NOOP only as a fallback,
is also seen in some other Qdiscs.

The only driver currently offloading PRIO (and thus presumably the only one
impacted by this) is mlxsw. Therefore patch #1 extends mlxsw to handle the
replacement by an invisible FIFO gracefully.

Petr Machata (2):
  mlxsw: spectrum_qdisc: Ignore grafting of invisible FIFO
  net: sch_prio: When ungrafting, replace with FIFO

 drivers/net/ethernet/mellanox/mlxsw/spectrum_qdisc.c |  7 +++++++
 net/sched/sch_prio.c                                 | 10 ++++++++--
 2 files changed, 15 insertions(+), 2 deletions(-)

-- 
2.20.1


             reply	other threads:[~2020-01-06 18:01 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-06 18:01 Petr Machata [this message]
2020-01-06 18:01 ` [PATCH net 1/2] mlxsw: spectrum_qdisc: Ignore grafting of invisible FIFO Petr Machata
2020-01-06 18:01 ` [PATCH net 2/2] net: sch_prio: When ungrafting, replace with FIFO Petr Machata
2020-01-08 20:47 ` [PATCH net 0/2] When ungrafting from PRIO, replace child " David Miller
     [not found] ` <87eewcfoe0.fsf@mellanox.com>
2020-01-08 20:48   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1578333529.git.petrm@mellanox.com \
    --to=petrm@mellanox.com \
    --cc=jiri@mellanox.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).