netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Petr Machata <pmachata@gmail.com>
To: netdev@vger.kernel.org
Cc: Petr Machata <pmachata@gmail.com>,
	David Ahern <dsahern@gmail.com>,
	Ido Schimmel <idosch@mellanox.com>
Subject: [PATCH iproute2-next 0/2] Add support for the ETS Qdisc
Date: Mon, 13 Jan 2020 15:16:27 +0100	[thread overview]
Message-ID: <cover.1578924154.git.petrm@mellanox.com> (raw)

A new Qdisc, "ETS", has been accepted into Linux at kernel commit
6bff00170277 ("Merge branch 'ETS-qdisc'"). Add iproute2 support for this
Qdisc.

Patch #1, changes libnetlink to admit NLA_F_NESTED in nested attributes.
Patch #2 then adds ETS support as such.

Examples (taken from the kernel patchset):

- Add a Qdisc with 6 bands, 3 strict and 3 ETS with 45%-30%-25% weights:

    # tc qdisc add dev swp1 root handle 1: \
	ets strict 3 quanta 4500 3000 2500 priomap 0 1 1 1 2 3 4 5
    # tc qdisc sh dev swp1
    qdisc ets 1: root refcnt 2 bands 6 strict 3 quanta 4500 3000 2500 priomap 0 1 1 1 2 3 4 5 5 5 5 5 5 5 5 5 

- Tweak quantum of one of the classes of the previous Qdisc:

    # tc class ch dev swp1 classid 1:4 ets quantum 1000
    # tc qdisc sh dev swp1
    qdisc ets 1: root refcnt 2 bands 6 strict 3 quanta 1000 3000 2500 priomap 0 1 1 1 2 3 4 5 5 5 5 5 5 5 5 5 
    # tc class ch dev swp1 classid 1:3 ets quantum 1000
    Error: Strict bands do not have a configurable quantum.

- Purely strict Qdisc with 1:1 mapping between priorities and TCs:

    # tc qdisc add dev swp1 root handle 1: \
	ets strict 8 priomap 7 6 5 4 3 2 1 0
    # tc qdisc sh dev swp1
    qdisc ets 1: root refcnt 2 bands 8 strict 8 priomap 7 6 5 4 3 2 1 0 7 7 7 7 7 7 7 7 

- Use "bands" to specify number of bands explicitly. Underspecified bands
  are implicitly ETS and their quantum is taken from MTU. The following
  thus gives each band the same weight:

    # tc qdisc add dev swp1 root handle 1: \
	ets bands 8 priomap 7 6 5 4 3 2 1 0
    # tc qdisc sh dev swp1
    qdisc ets 1: root refcnt 2 bands 8 quanta 1514 1514 1514 1514 1514 1514 1514 1514 priomap 7 6 5 4 3 2 1 0 7 7 7 7 7 7 7 7 

Petr Machata (2):
  libnetlink: parse_rtattr_nested should allow NLA_F_NESTED flag
  tc: Add support for ETS Qdisc

 include/libnetlink.h |   3 +-
 man/man8/tc-ets.8    | 192 ++++++++++++++++++++++++
 man/man8/tc.8        |   7 +
 tc/Makefile          |   1 +
 tc/q_ets.c           | 342 +++++++++++++++++++++++++++++++++++++++++++
 5 files changed, 544 insertions(+), 1 deletion(-)
 create mode 100644 man/man8/tc-ets.8
 create mode 100644 tc/q_ets.c

-- 
2.20.1


             reply	other threads:[~2020-01-13 14:21 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-13 14:16 Petr Machata [this message]
2020-01-13 14:16 ` [PATCH iproute2-next 1/2] libnetlink: parse_rtattr_nested should allow NLA_F_NESTED flag Petr Machata
2020-01-13 14:16 ` [PATCH iproute2-next 2/2] tc: Add support for ETS Qdisc Petr Machata
2020-01-18 21:58 ` [PATCH iproute2-next 0/2] Add support for the " David Ahern

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1578924154.git.petrm@mellanox.com \
    --to=pmachata@gmail.com \
    --cc=dsahern@gmail.com \
    --cc=idosch@mellanox.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).