From: Finn Thain <fthain@telegraphics.com.au>
To: "David S. Miller" <davem@davemloft.net>
Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Chris Zankel <chris@zankel.net>,
Laurent Vivier <laurent@vivier.eu>,
Geert Uytterhoeven <geert@linux-m68k.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH net v2 00/12] Fixes for SONIC ethernet driver
Date: Wed, 22 Jan 2020 08:22:08 +1100 [thread overview]
Message-ID: <cover.1579641728.git.fthain@telegraphics.com.au> (raw)
Hi David,
Various SONIC driver problems have become apparent over the years,
including tx watchdog timeouts, lost packets and duplicated packets.
The problems are mostly caused by bugs in buffer handling, locking and
(re-)initialization code.
This patch series resolves these problems.
This series has been tested on National Semiconductor hardware (macsonic),
qemu-system-m68k (macsonic) and qemu-system-mips64el (jazzsonic).
The emulated dp8393x device used in QEMU also has bugs.
I have fixed the bugs that I know of in a series of patches at,
https://github.com/fthain/qemu/commits/sonic
---
Changed since v1:
- Minor revisions as described in commit logs.
- Deferred net-next patches.
Finn Thain (12):
net/sonic: Add mutual exclusion for accessing shared state
net/sonic: Clear interrupt flags immediately
net/sonic: Use MMIO accessors
net/sonic: Fix interface error stats collection
net/sonic: Fix receive buffer handling
net/sonic: Avoid needless receive descriptor EOL flag updates
net/sonic: Improve receive descriptor status flag check
net/sonic: Fix receive buffer replenishment
net/sonic: Quiesce SONIC before re-initializing descriptor memory
net/sonic: Fix command register usage
net/sonic: Fix CAM initialization
net/sonic: Prevent tx watchdog timeout
drivers/net/ethernet/natsemi/sonic.c | 380 ++++++++++++++++-----------
drivers/net/ethernet/natsemi/sonic.h | 44 +++-
2 files changed, 262 insertions(+), 162 deletions(-)
--
2.24.1
next reply other threads:[~2020-01-21 22:11 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-21 21:22 Finn Thain [this message]
2020-01-21 21:22 ` [PATCH net v2 02/12] net/sonic: Clear interrupt flags immediately Finn Thain
2020-01-21 21:22 ` [PATCH net v2 06/12] net/sonic: Avoid needless receive descriptor EOL flag updates Finn Thain
2020-01-21 21:22 ` [PATCH net v2 05/12] net/sonic: Fix receive buffer handling Finn Thain
2020-01-21 22:23 ` Stephen Hemminger
2020-01-21 23:53 ` Finn Thain
2020-01-21 21:22 ` [PATCH net v2 10/12] net/sonic: Fix command register usage Finn Thain
2020-01-21 21:22 ` [PATCH net v2 11/12] net/sonic: Fix CAM initialization Finn Thain
2020-01-21 21:22 ` [PATCH net v2 04/12] net/sonic: Fix interface error stats collection Finn Thain
2020-01-21 21:22 ` [PATCH net v2 07/12] net/sonic: Improve receive descriptor status flag check Finn Thain
2020-01-21 21:22 ` [PATCH net v2 09/12] net/sonic: Quiesce SONIC before re-initializing descriptor memory Finn Thain
2020-01-21 21:22 ` [PATCH net v2 08/12] net/sonic: Fix receive buffer replenishment Finn Thain
2020-01-21 21:22 ` [PATCH net v2 03/12] net/sonic: Use MMIO accessors Finn Thain
2020-01-21 21:22 ` [PATCH net v2 01/12] net/sonic: Add mutual exclusion for accessing shared state Finn Thain
2020-01-21 22:19 ` Eric Dumazet
2020-01-21 23:33 ` Finn Thain
2020-01-21 23:52 ` Eric Dumazet
2020-01-22 0:40 ` Finn Thain
2020-01-21 21:22 ` [PATCH net v2 12/12] net/sonic: Prevent tx watchdog timeout Finn Thain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1579641728.git.fthain@telegraphics.com.au \
--to=fthain@telegraphics.com.au \
--cc=chris@zankel.net \
--cc=davem@davemloft.net \
--cc=geert@linux-m68k.org \
--cc=laurent@vivier.eu \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).