From: Yulia Kartseva <hex@fb.com>
To: <bpf@vger.kernel.org>, <hex@fb.com>, <ast@kernel.org>,
<daniel@iogearbox.net>, <netdev@vger.kernel.org>
Cc: <andriin@fb.com>
Subject: [PATCH bpf 0/1] runqslower: fix Makefile
Date: Wed, 29 Jan 2020 18:09:05 -0800 [thread overview]
Message-ID: <cover.1580348836.git.hex@fb.com> (raw)
From: Julia Kartseva <hex@fb.com>
Fix undefined reference linker errors when building runqslower with
gcc 7.4.0 on Ubuntu 18.04.
The issue is with misplaced -lelf, -lz options in Makefile:
$(Q)$(CC) $(CFLAGS) -lelf -lz $^ -o $@
-lelf, -lz options should follow the list of target dependencies:
$(Q)$(CC) $(CFLAGS) $^ -lelf -lz -o $@
or after substitution
cc -g -Wall runqslower.o libbpf.a -lelf -lz -o runqslower
The current order of gcc params causes failure in libelf symbols resolution,
e.g. undefined reference to `elf_memory'
Julia Kartseva (1):
runqslower: fix Makefile
tools/bpf/runqslower/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
2.17.1
next reply other threads:[~2020-01-30 2:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-30 2:09 Yulia Kartseva [this message]
2020-01-30 2:09 ` [PATCH bpf 1/1] runqslower: fix Makefile Yulia Kartseva
2020-01-30 2:37 ` Andrii Nakryiko
2020-01-30 2:38 ` Andrii Nakryiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1580348836.git.hex@fb.com \
--to=hex@fb.com \
--cc=andriin@fb.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).