netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Michal Kubecek <mkubecek@suse.cz>
To: John Linville <linville@tuxdriver.com>, netdev@vger.kernel.org
Cc: Andrew Lunn <andrew@lunn.ch>
Subject: [PATCH ethtool 0/2] improve the logic of fallback from netlink to ioctl
Date: Wed, 29 Apr 2020 00:30:00 +0200 (CEST)	[thread overview]
Message-ID: <cover.1588112572.git.mkubecek@suse.cz> (raw)

At the moment, ethtool falls back to ioctl implementation whenever either
in response to request type not implemented in kernel or netlink interface
is unavailable or netlink request fails with EOPNOTSUPP error code. This is
not perfect as EOPNOTSUPP can have different meanings and we only want to
fall back if it is caused by kernel lacking netlink implementation of the
request. In other cases, we would needlessly repeat the same failure trying
both netlink and ioctl.

These two patches improve the logic to avoid such duplicate failures and
improve handling of cases where fallback to ioctl is impossible for other
reasons (e.g. wildcard device name or no ioctl handler).

Michal Kubecek (2):
  refactor interface between ioctl and netlink code
  netlink: use genetlink ops information to decide about fallback

 ethtool.c          |  51 +++---------
 netlink/extapi.h   |  14 ++--
 netlink/monitor.c  |  15 +++-
 netlink/netlink.c  | 193 ++++++++++++++++++++++++++++++++++++++-------
 netlink/netlink.h  |   6 ++
 netlink/parser.c   |   7 ++
 netlink/settings.c |   7 ++
 7 files changed, 220 insertions(+), 73 deletions(-)

-- 
2.26.2


             reply	other threads:[~2020-04-28 22:30 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-28 22:30 Michal Kubecek [this message]
2020-04-28 22:30 ` [PATCH ethtool 1/2] refactor interface between ioctl and netlink code Michal Kubecek
2020-04-28 22:30 ` [PATCH ethtool 2/2] netlink: use genetlink ops information to decide about fallback Michal Kubecek
2020-05-13 19:58 ` [PATCH ethtool 0/2] improve the logic of fallback from netlink to ioctl John W. Linville

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1588112572.git.mkubecek@suse.cz \
    --to=mkubecek@suse.cz \
    --cc=andrew@lunn.ch \
    --cc=linville@tuxdriver.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).