From: Rylan Dmello <mail@rylan.coffee>
To: Manish Chopra <manishc@marvell.com>,
GR-Linux-NIC-Dev@marvell.com,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
netdev@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, Joe Perches <joe@perches.com>
Subject: [PATCH v2 0/7] staging: qlge: Checkpatch.pl indentation fixes in qlge_main.c
Date: Wed, 29 Apr 2020 21:31:54 -0400 [thread overview]
Message-ID: <cover.1588209862.git.mail@rylan.coffee> (raw)
This patchset fixes some indentation- and style-related issues in qlge_main.c
reported by checkpatch.pl, such as:
WARNING: Avoid multiple line dereference
WARNING: line over 80 characters
WARNING: suspect code indent for conditional statements
v2:
- Addressed feedback from Joe Perches by unindenting
ql_set_mac_addr_reg and by replacing goto statements with break
statements in the function.
Rylan Dmello (7):
staging: qlge: Fix indentation in ql_set_mac_addr_reg
staging: qlge: Remove gotos from ql_set_mac_addr_reg
staging: qlge: Fix indentation in ql_get_mac_addr_reg
staging: qlge: Remove goto statements from ql_get_mac_addr_reg
staging: qlge: Remove multi-line dereference from ql_request_irq
staging: qlge: Fix suspect code indent warning in ql_init_device
staging: qlge: Fix function argument alignment warning in
ql_init_device
drivers/staging/qlge/qlge_main.c | 258 ++++++++++++++-----------------
1 file changed, 120 insertions(+), 138 deletions(-)
--
2.26.2
next reply other threads:[~2020-04-30 1:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-30 1:31 Rylan Dmello [this message]
2020-04-30 1:32 ` [PATCH v2 1/7] staging: qlge: Fix indentation in ql_set_mac_addr_reg Rylan Dmello
2020-04-30 1:33 ` [PATCH v2 2/7] staging: qlge: Remove gotos from ql_set_mac_addr_reg Rylan Dmello
2020-04-30 9:38 ` Dan Carpenter
2020-04-30 10:03 ` Joe Perches
2020-04-30 10:08 ` Dan Carpenter
2020-04-30 1:33 ` [PATCH v2 3/7] staging: qlge: Fix indentation in ql_get_mac_addr_reg Rylan Dmello
2020-04-30 1:33 ` [PATCH v2 4/7] staging: qlge: Remove goto statements from ql_get_mac_addr_reg Rylan Dmello
2020-04-30 1:34 ` [PATCH v2 5/7] staging: qlge: Remove multi-line dereference from ql_request_irq Rylan Dmello
2020-04-30 1:34 ` [PATCH v2 6/7] staging: qlge: Fix suspect code indent warning in ql_init_device Rylan Dmello
2020-04-30 1:35 ` [PATCH v2 7/7] staging: qlge: Fix function argument alignment " Rylan Dmello
2020-04-30 1:51 ` [PATCH v2 0/7] staging: qlge: Checkpatch.pl indentation fixes in qlge_main.c Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1588209862.git.mail@rylan.coffee \
--to=mail@rylan.coffee \
--cc=GR-Linux-NIC-Dev@marvell.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=manishc@marvell.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).