From: Guillaume Nault <gnault@redhat.com>
To: David Miller <davem@davemloft.net>, Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org, Jamal Hadi Salim <jhs@mojatatu.com>,
Cong Wang <xiyou.wangcong@gmail.com>,
Jiri Pirko <jiri@mellanox.com>, Tom Herbert <tom@herbertland.com>,
Pablo Neira Ayuso <pablo@netfilter.org>,
Eli Cohen <eli@mellanox.com>, Liel Shoshan <liels@mellanox.com>,
Rony Efraim <ronye@mellanox.com>
Subject: [PATCH net-next v3 0/2] flow_dissector, cls_flower: Add support for multiple MPLS Label Stack Entries
Date: Tue, 26 May 2020 14:28:57 +0200 [thread overview]
Message-ID: <cover.1590495493.git.gnault@redhat.com> (raw)
Currently, the flow dissector and the Flower classifier can only handle
the first entry of an MPLS label stack. This patch series generalises
the code to allow parsing and matching the Label Stack Entries that
follow.
Patch 1 extends the flow dissector to parse MPLS LSEs until the Bottom
Of Stack bit is reached. The number of parsed LSEs is capped at
FLOW_DIS_MPLS_MAX (arbitrarily set to 7). Flower and the NFP driver
are updated to take into account the new layout of struct
flow_dissector_key_mpls.
Patch 2 extends Flower. It defines new netlink attributes, which are
independent from the previous MPLS ones. Mixing the old and the new
attributes in a same filter is not allowed. For backward compatibility,
the old attributes are used when dumping filters that don't require the
new ones.
Changes since v2:
* Fix compilation with the new MLX5 bareudp tunnel code.
Changes since v1:
* Fix compilation of NFP driver (kbuild test robot).
* Fix sparse warning with entropy label (kbuild test robot).
Guillaume Nault (2):
flow_dissector: Parse multiple MPLS Label Stack Entries
cls_flower: Support filtering on multiple MPLS Label Stack Entries
.../mellanox/mlx5/core/en/tc_tun_mplsoudp.c | 27 +-
.../net/ethernet/netronome/nfp/flower/match.c | 42 ++-
include/net/flow_dissector.h | 14 +-
include/uapi/linux/pkt_cls.h | 23 ++
net/core/flow_dissector.c | 49 ++-
net/sched/cls_flower.c | 295 +++++++++++++++++-
6 files changed, 397 insertions(+), 53 deletions(-)
--
2.21.1
Notes:
* The NFP and MLX5 udpates have been compile-tested only, as I don't
don't have the required hardware. Reviews from Netronome and
Mellanox warmly welcome.
* Compiles with allmodconfig on latest net-next tree, I swear :)
next reply other threads:[~2020-05-26 12:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-26 12:28 Guillaume Nault [this message]
2020-05-26 12:29 ` [PATCH net-next v3 1/2] flow_dissector: Parse multiple MPLS Label Stack Entries Guillaume Nault
2020-05-26 12:29 ` [PATCH net-next v3 2/2] cls_flower: Support filtering on " Guillaume Nault
2020-05-26 22:23 ` [PATCH net-next v3 0/2] flow_dissector, cls_flower: Add support for " David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1590495493.git.gnault@redhat.com \
--to=gnault@redhat.com \
--cc=davem@davemloft.net \
--cc=eli@mellanox.com \
--cc=jhs@mojatatu.com \
--cc=jiri@mellanox.com \
--cc=kuba@kernel.org \
--cc=liels@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=ronye@mellanox.com \
--cc=tom@herbertland.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).