From: Petr Machata <petrm@mellanox.com>
To: netdev@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Petr Machata <petrm@mellanox.com>
Subject: [PATCH net-next 0/2] selftests: forwarding: Two small changes
Date: Fri, 29 May 2020 14:16:52 +0300 [thread overview]
Message-ID: <cover.1590749356.git.petrm@mellanox.com> (raw)
Two unrelated changes in this patchset:
- In patch #1, convert mirror tests from using ping directly to generating
ICMP packets by mausezahn. Using ping in tests is error-prone, because
ping is too smart. On a flaky system (notably in a simulator), when
packets don't come quickly enough, more pings are sent, and that throws
off counters. This was worked around in the past by just pinging more
slowly, but using mausezahn avoids the issue as well without making the
tests unnecessary slow.
- A missing stats_update callback was recently added to act_pedit. Now that
iproute2 supports JSON dumping for pedit, extend in patch #2 the
pedit_dsfield selftest with a check that would have caught the fact that
the callback was missing.
Petr Machata (2):
selftests: forwarding: mirror_lib: Use mausezahn
selftests: forwarding: pedit_dsfield: Check counter value
tools/testing/selftests/net/forwarding/mirror_lib.sh | 6 ++----
tools/testing/selftests/net/forwarding/pedit_dsfield.sh | 7 ++++++-
2 files changed, 8 insertions(+), 5 deletions(-)
--
2.20.1
next reply other threads:[~2020-05-29 11:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-29 11:16 Petr Machata [this message]
2020-05-29 11:16 ` [PATCH net-next 1/2] selftests: forwarding: mirror_lib: Use mausezahn Petr Machata
2020-05-29 11:16 ` [PATCH net-next 2/2] selftests: forwarding: pedit_dsfield: Check counter value Petr Machata
2020-05-31 4:49 ` [PATCH net-next 0/2] selftests: forwarding: Two small changes David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1590749356.git.petrm@mellanox.com \
--to=petrm@mellanox.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).