netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Abeni <pabeni@redhat.com>
To: netdev@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	Mat Martineau <mathew.j.martineau@linux.intel.com>,
	Eric Dumazet <edumazet@google.com>,
	mptcp@lists.linux.dev
Subject: [PATCH net-next 0/4] net: remove sk skb caches
Date: Wed, 22 Sep 2021 19:26:39 +0200	[thread overview]
Message-ID: <cover.1632318035.git.pabeni@redhat.com> (raw)

Eric noted we would be better off reverting the sk
skb caches.

MPTCP relies on such a feature, so we need a
little refactor of the MPTCP tx path before the mentioned
revert.

The first patch exposes additional TCP helpers. The 2nd patch
changes the MPTCP code to do locally the whole skb allocation
and updating, so it does not rely anymore on core TCP helpers
for that nor the sk skb cache.

As a side effect, we can make the tcp_build_frag helper static.

Finally, we can pull Eric's revert.

RFC -> v1:
 - drop driver specific patch - no more needed after helper rename
 - rename skb_entail -> tcp_skb_entail (Eric)
 - preserve the tcp_build_frag helpwe, just make it static (Eric)

---
Note:

that this series touches some LoC also modifed by this -net patch:

https://patchwork.kernel.org/project/netdevbpf/patch/706c577fde04fbb8285c8fc078a2c6d0a4bf9564.1632309038.git.pabeni@redhat.com/

so the whole series is based on top of the above and will apply
with no conflict after such patch will land into net-next

Eric Dumazet (1):
  tcp: remove sk_{tr}x_skb_cache

Paolo Abeni (3):
  tcp: expose the tcp_mark_push() and tcp_skb_entail() helpers
  mptcp: stop relying on tcp_tx_skb_cache
  tcp: make tcp_build_frag() static

 Documentation/networking/ip-sysctl.rst |   8 --
 include/net/sock.h                     |  19 ----
 include/net/tcp.h                      |   4 +-
 net/ipv4/af_inet.c                     |   4 -
 net/ipv4/sysctl_net_ipv4.c             |  12 ---
 net/ipv4/tcp.c                         |  38 ++-----
 net/ipv4/tcp_ipv4.c                    |   6 --
 net/ipv6/tcp_ipv6.c                    |   6 --
 net/mptcp/protocol.c                   | 137 ++++++++++++++-----------
 9 files changed, 85 insertions(+), 149 deletions(-)

-- 
2.26.3


             reply	other threads:[~2021-09-22 17:27 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-22 17:26 Paolo Abeni [this message]
2021-09-22 17:26 ` [PATCH net-next 1/4] tcp: expose the tcp_mark_push() and tcp_skb_entail() helpers Paolo Abeni
2021-09-22 17:59   ` Eric Dumazet
2021-09-22 17:26 ` [PATCH net-next 2/4] mptcp: stop relying on tcp_tx_skb_cache Paolo Abeni
2021-09-22 17:26 ` [PATCH net-next 3/4] tcp: make tcp_build_frag() static Paolo Abeni
2021-09-22 18:00   ` Eric Dumazet
2021-09-22 17:26 ` [PATCH net-next 4/4] tcp: remove sk_{tr}x_skb_cache Paolo Abeni
2021-09-22 18:01   ` Eric Dumazet
2021-09-23 12:00 ` [PATCH net-next 0/4] net: remove sk skb caches patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1632318035.git.pabeni@redhat.com \
    --to=pabeni@redhat.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=mathew.j.martineau@linux.intel.com \
    --cc=mptcp@lists.linux.dev \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).