From: Christian Schoenebeck <linux_oss@crudebyte.com>
To: v9fs-developer@lists.sourceforge.net
Cc: netdev@vger.kernel.org,
Dominique Martinet <asmadeus@codewreck.org>,
Eric Van Hensbergen <ericvh@gmail.com>,
Latchesar Ionkov <lucho@ionkov.net>, Greg Kurz <groug@kaod.org>,
Vivek Goyal <vgoyal@redhat.com>
Subject: [PATCH v3 0/7] net/9p: remove msize limit in virtio transport
Date: Wed, 22 Sep 2021 18:00:18 +0200 [thread overview]
Message-ID: <cover.1632327421.git.linux_oss@crudebyte.com> (raw)
This series aims to get get rid of the current 500k 'msize' limitation in
the 9p virtio transport, which is currently a bottleneck for performance
of 9p mounts.
This is a follow-up of the following series and discussion:
https://lore.kernel.org/all/28bb651ae0349a7d57e8ddc92c1bd5e62924a912.1630770829.git.linux_oss@crudebyte.com/T/#eb647d0c013616cee3eb8ba9d87da7d8b1f476f37
Known limitation: With this series applied I can run
QEMU host <-> 9P virtio <-> Linux guest
with up to 3 MB msize. If I try to run it with 4 MB it seems to hit some
limitation on QEMU side:
qemu-system-x86_64: virtio: too many write descriptors in indirect table
I haven't looked into this issue yet.
Prerequisites: If you are testing with QEMU then please apply the following
patch on QEMU side:
https://lore.kernel.org/qemu-devel/E1mT2Js-0000DW-OH@lizzy.crudebyte.com/
That QEMU patch is required if you are using a user space app that
automatically retrieves an optimum I/O block size by obeying stat's
st_blksize, which 'cat' for instance is doing, e.g.:
time cat test_rnd.dat > /dev/null
Otherwise please use a user space app for performance testing that allows
you to force a large block size and to avoid that QEMU issue, like 'dd'
for instance, in that case you don't need to patch QEMU.
Testing and feedback appreciated!
v2 -> v3:
* Make vq_sg_free() safe for NULL argument [patch 4].
* Show info message to user if user's msize option had to be limited in
case it would exceed p9_max_pages [patch 6].
* Fix memory leak in vq_sg_resize() [patch 7].
* Show info message to user if user's msize option had to be limited in
case not all required SG lists could be allocated [patch 7].
Christian Schoenebeck (7):
net/9p: show error message if user 'msize' cannot be satisfied
9p/trans_virtio: separate allocation of scatter gather list
9p/trans_virtio: turn amount of sg lists into runtime info
9p/trans_virtio: introduce struct virtqueue_sg
net/9p: add trans_maxsize to struct p9_client
9p/trans_virtio: support larger msize values
9p/trans_virtio: resize sg lists to whatever is possible
include/net/9p/client.h | 2 +
net/9p/client.c | 17 ++-
net/9p/trans_virtio.c | 304 +++++++++++++++++++++++++++++++++++-----
3 files changed, 283 insertions(+), 40 deletions(-)
--
2.20.1
next reply other threads:[~2021-09-22 17:30 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-22 16:00 Christian Schoenebeck [this message]
2021-09-22 16:00 ` [PATCH v3 1/7] net/9p: show error message if user 'msize' cannot be satisfied Christian Schoenebeck
2021-09-22 16:00 ` [PATCH v3 2/7] 9p/trans_virtio: separate allocation of scatter gather list Christian Schoenebeck
2021-09-22 16:00 ` [PATCH v3 3/7] 9p/trans_virtio: turn amount of sg lists into runtime info Christian Schoenebeck
2021-09-22 16:00 ` [PATCH v3 4/7] 9p/trans_virtio: introduce struct virtqueue_sg Christian Schoenebeck
2021-09-22 16:00 ` [PATCH v3 5/7] net/9p: add trans_maxsize to struct p9_client Christian Schoenebeck
2021-09-22 16:00 ` [PATCH v3 6/7] 9p/trans_virtio: support larger msize values Christian Schoenebeck
2021-11-20 11:20 ` Nikolay Kichukov
2021-11-20 11:45 ` Dominique Martinet
2021-11-20 14:46 ` Christian Schoenebeck
2021-11-20 21:28 ` Nikolay Kichukov
2021-11-20 23:02 ` Dominique Martinet
2021-11-21 16:57 ` Christian Schoenebeck
2021-11-21 22:12 ` Dominique Martinet
2021-11-22 13:32 ` Christian Schoenebeck
2021-11-22 22:35 ` Dominique Martinet
2021-11-24 12:22 ` Christian Schoenebeck
2021-09-22 16:00 ` [PATCH v3 7/7] 9p/trans_virtio: resize sg lists to whatever is possible Christian Schoenebeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1632327421.git.linux_oss@crudebyte.com \
--to=linux_oss@crudebyte.com \
--cc=asmadeus@codewreck.org \
--cc=ericvh@gmail.com \
--cc=groug@kaod.org \
--cc=lucho@ionkov.net \
--cc=netdev@vger.kernel.org \
--cc=v9fs-developer@lists.sourceforge.net \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).