netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
To: Chandrasekar Ramakrishnan <rcsekar@samsung.com>,
	Wolfgang Grandegger <wg@grandegger.com>,
	Marc Kleine-Budde <mkl@pengutronix.de>
Cc: "David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	"Felipe Balbi (Intel)" <balbi@kernel.org>,
	Jarkko Nikula <jarkko.nikula@linux.intel.com>,
	linux-can@vger.kernel.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
Subject: [PATCH net 0/4] Fix bit timings for m_can_pci (Elkhart Lake)
Date: Mon, 15 Nov 2021 10:18:48 +0100	[thread overview]
Message-ID: <cover.1636967198.git.matthias.schiffer@ew.tq-group.com> (raw)

This series fixes two issues we found with the setup of the CAN
controller of Intel Elkhart Lake CPUs:

- Patch 1 fixes an incorrect reference clock rate, which caused the
  configured and the actual bitrate always to differ by a factor of 2.
- Patches 2-4 fix a deviation between the driver and the documentation.
  We did not actually see issues without these patches, however we did
  only superficial testing and may just not have hit the specific
  bittiming values that violate the documented limits.


Matthias Schiffer (4):
  can: m_can: pci: fix incorrect reference clock rate
  Revert "can: m_can: remove support for custom bit timing"
  can: m_can: make custom bittiming fields const
  can: m_can: pci: use custom bit timings for Elkhart Lake

 drivers/net/can/m_can/m_can.c     | 24 ++++++++++++----
 drivers/net/can/m_can/m_can.h     |  3 ++
 drivers/net/can/m_can/m_can_pci.c | 48 ++++++++++++++++++++++++++++---
 3 files changed, 65 insertions(+), 10 deletions(-)

-- 
2.17.1


             reply	other threads:[~2021-11-15  9:21 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-15  9:18 Matthias Schiffer [this message]
2021-11-15  9:18 ` [PATCH net 1/4] can: m_can: pci: fix incorrect reference clock rate Matthias Schiffer
2021-11-15 14:48   ` Jarkko Nikula
2021-11-16  7:11     ` Jarkko Nikula
2021-11-16  7:15       ` Marc Kleine-Budde
2021-11-16 14:50         ` Jarkko Nikula
2021-11-15  9:18 ` [PATCH net 2/4] Revert "can: m_can: remove support for custom bit timing" Matthias Schiffer
2021-11-15  9:18 ` [PATCH net 3/4] can: m_can: make custom bittiming fields const Matthias Schiffer
2021-11-15  9:18 ` [PATCH net 4/4] can: m_can: pci: use custom bit timings for Elkhart Lake Matthias Schiffer
2021-11-16 13:58 ` [PATCH net 0/4] Fix bit timings for m_can_pci (Elkhart Lake) Matthias Schiffer
2021-11-17 12:14   ` Jarkko Nikula
2021-11-18 14:47     ` Matthias Schiffer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1636967198.git.matthias.schiffer@ew.tq-group.com \
    --to=matthias.schiffer@ew.tq-group.com \
    --cc=balbi@kernel.org \
    --cc=davem@davemloft.net \
    --cc=jarkko.nikula@linux.intel.com \
    --cc=kuba@kernel.org \
    --cc=linux-can@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mkl@pengutronix.de \
    --cc=netdev@vger.kernel.org \
    --cc=rcsekar@samsung.com \
    --cc=wg@grandegger.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).