From: Andrea Claudi <aclaudi@redhat.com>
To: netdev@vger.kernel.org
Cc: stephen@networkplumber.org, dsahern@gmail.com,
markzhang@nvidia.com, leonro@nvidia.com
Subject: [PATCH iproute2 v3 0/2] fix memory leak in get_task_name()
Date: Tue, 8 Mar 2022 18:04:55 +0100 [thread overview]
Message-ID: <cover.1646750928.git.aclaudi@redhat.com> (raw)
This series fixes some memory leaks related to the usage of the
get_task_name() function from lib/fs.c.
Patch 2/2 addresses a coverity warning related to this memory leak,
making the code a bit more readable by humans and coverity.
Changelog:
----------
v2 -> v3
- Use a better API for get_task_name(), passing to it a buffer and its
lenght just like get_command_name().
v1 -> v2
- on Stephen's suggestion, drop asprintf() and use a local var for path;
additionally drop %m from fscanf to not allocate memory, and resort to
a param to return task name to the caller.
- patch 2/3 of the original series is no more needed.
Andrea Claudi (2):
lib/fs: fix memory leak in get_task_name()
rdma: make RES_PID and RES_KERN_NAME alternative to each other
include/utils.h | 2 +-
ip/iptuntap.c | 17 ++++++++++-------
lib/fs.c | 23 +++++++++++++----------
rdma/res-cmid.c | 18 +++++++++---------
rdma/res-cq.c | 17 +++++++++--------
rdma/res-ctx.c | 16 ++++++++--------
rdma/res-mr.c | 15 ++++++++-------
rdma/res-pd.c | 17 +++++++++--------
rdma/res-qp.c | 16 ++++++++--------
rdma/res-srq.c | 17 +++++++++--------
rdma/stat.c | 14 +++++++++-----
11 files changed, 93 insertions(+), 79 deletions(-)
--
2.35.1
next reply other threads:[~2022-03-08 17:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-08 17:04 Andrea Claudi [this message]
2022-03-08 17:04 ` [PATCH iproute2 v3 1/2] lib/fs: fix memory leak in get_task_name() Andrea Claudi
2022-03-08 17:30 ` Stephen Hemminger
2022-03-08 17:04 ` [PATCH iproute2 v3 2/2] rdma: make RES_PID and RES_KERN_NAME alternative to each other Andrea Claudi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1646750928.git.aclaudi@redhat.com \
--to=aclaudi@redhat.com \
--cc=dsahern@gmail.com \
--cc=leonro@nvidia.com \
--cc=markzhang@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).