From: Guillaume Nault <gnault@redhat.com>
To: David Miller <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: netdev@vger.kernel.org,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
David Ahern <dsahern@kernel.org>, Shuah Khan <shuah@kernel.org>,
linux-kselftest@vger.kernel.org
Subject: [PATCH net v2 0/2] ipv4: Handle TOS and scope properly for ICMP redirects and PMTU updates
Date: Thu, 17 Mar 2022 13:45:05 +0100 [thread overview]
Message-ID: <cover.1647519748.git.gnault@redhat.com> (raw)
ICMPv4 PMTU and redirect handlers didn't properly initialise the
struct flowi4 they used for route lookups:
* ECN bits sometimes weren't cleared from ->flowi4_tos.
* The RTO_ONLINK flag wasn't taken into account for ->flowi4_scope.
In some special cases, this resulted in ICMP redirects and PMTU updates
not being taken into account because fib_lookup() couldn't retrieve the
correct route.
Changes since v1:
* Fix 'Fixes' tag in patch 1 (David Ahern).
* Add kernel seltest (David Ahern).
Guillaume Nault (2):
ipv4: Fix route lookups when handling ICMP redirects and PMTU updates
selftest: net: Test IPv4 PMTU exceptions with DSCP and ECN
net/ipv4/route.c | 18 +++-
tools/testing/selftests/net/pmtu.sh | 141 +++++++++++++++++++++++++++-
2 files changed, 151 insertions(+), 8 deletions(-)
--
2.21.3
next reply other threads:[~2022-03-17 12:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-17 12:45 Guillaume Nault [this message]
2022-03-17 12:45 ` [PATCH net v2 1/2] ipv4: Fix route lookups when handling ICMP redirects and PMTU updates Guillaume Nault
2022-03-17 18:40 ` David Ahern
2022-03-17 12:45 ` [PATCH net v2 2/2] selftest: net: Test IPv4 PMTU exceptions with DSCP and ECN Guillaume Nault
2022-03-17 18:42 ` David Ahern
2022-03-18 21:20 ` [PATCH net v2 0/2] ipv4: Handle TOS and scope properly for ICMP redirects and PMTU updates patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1647519748.git.gnault@redhat.com \
--to=gnault@redhat.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).