netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Qiao Ma <mqaio@linux.alibaba.com>
To: davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
	kuba@kernel.org, gustavoars@kernel.org, cai.huoqing@linux.dev,
	aviad.krawczyk@huawei.com, zhaochen6@huawei.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH net-next v3 0/3] net: hinic: fix three bugs about dev_get_stats
Date: Tue,  5 Jul 2022 14:25:58 +0800	[thread overview]
Message-ID: <cover.1657001998.git.mqaio@linux.alibaba.com> (raw)

These patches fixes 3 bugs of hinic driver:
- fix bug that ethtool get wrong stats because of hinic_{txq|rxq}_clean_stats() is called
- avoid kernel hung in hinic_get_stats64() 
- fix bug that u64_stats_sync is not initialized

See every patch for more information.

Changes in v3:
- fixes a compile warning reported by kernel test robot <lkp@intel.com>

Changes in v2:
- fixes another 2 bugs. (v1 is a single patch, see: https://lore.kernel.org/all/07736c2b7019b6883076a06129e06e8f7c5f7154.1656487154.git.mqaio@linux.alibaba.com/).
- to fix extra bugs, hinic_dev.tx_stats/rx_stats is removed, so there is no need to use spinlock or semaphore now. 

Qiao Ma (3):
  net: hinic: fix bug that ethtool get wrong stats
  net: hinic: avoid kernel hung in hinic_get_stats64()
  net: hinic: fix bug that u64_stats_sync is not initialized

 drivers/net/ethernet/huawei/hinic/hinic_dev.h     |  3 --
 drivers/net/ethernet/huawei/hinic/hinic_ethtool.c |  3 ++
 drivers/net/ethernet/huawei/hinic/hinic_main.c    | 58 +++++++----------------
 3 files changed, 21 insertions(+), 43 deletions(-)

-- 
1.8.3.1


             reply	other threads:[~2022-07-05  6:26 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-05  6:25 Qiao Ma [this message]
2022-07-05  6:25 ` [PATCH net-next v3 1/3] net: hinic: fix bug that ethtool get wrong stats Qiao Ma
2022-07-05  6:26 ` [PATCH net-next v3 2/3] net: hinic: avoid kernel hung in hinic_get_stats64() Qiao Ma
2022-07-05  6:26 ` [PATCH net-next v3 3/3] net: hinic: fix bug that u64_stats_sync is not initialized Qiao Ma
2022-07-05  8:53   ` Eric Dumazet
2022-07-05  9:09     ` maqiao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1657001998.git.mqaio@linux.alibaba.com \
    --to=mqaio@linux.alibaba.com \
    --cc=aviad.krawczyk@huawei.com \
    --cc=cai.huoqing@linux.dev \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=gustavoars@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=zhaochen6@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).