From: Binyi Han <dantengknight@gmail.com>
To: Manish Chopra <manishc@marvell.com>,
GR-Linux-NIC-Dev@marvell.com, Coiby Xu <coiby.xu@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Joe Perches <joe@perches.com>
Cc: netdev@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: [PATCH v4 0/2] staging: qlge: code refinement around a for loop
Date: Wed, 13 Jul 2022 00:57:58 -0700 [thread overview]
Message-ID: <cover.1657697683.git.dantengknight@gmail.com> (raw)
* Patch 1:
Fix indentation according to checkpatch.
Format the long for loop thanks to Joe's review.
* Patch 2:
Optimize by avoiding the multiplication thanks to Joe's
review.
I agree with Joe and think it's the same logic, and it
compiles without error.
But I don't have the real hardware, so can't prove that
code is still doing the same thing. So I understand if you
don't apply this patch without the "proof".
v4:
- Separate the code style change and "optimization" into 2 patches
v3:
Thanks to Joe's review.
- Align page_entries in the for loop to open parenthesis.
- Optimize by avoiding the multiplication.
v2:
- Change the long for loop into 3 lines
Binyi Han (2):
staging: qlge: Fix indentation issue under long for loop
staging: qlge: Avoid multiplication while keep the same logic
drivers/staging/qlge/qlge_main.c | 20 ++++++++++++--------
1 file changed, 12 insertions(+), 8 deletions(-)
--
2.25.1
next reply other threads:[~2022-07-13 7:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-13 7:57 Binyi Han [this message]
2022-07-13 7:59 ` [PATCH v4 1/2] staging: qlge: Fix indentation issue under long for loop Binyi Han
2022-07-13 8:00 ` [PATCH v4 2/2] staging: qlge: Avoid multiplication while keep the same logic Binyi Han
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1657697683.git.dantengknight@gmail.com \
--to=dantengknight@gmail.com \
--cc=GR-Linux-NIC-Dev@marvell.com \
--cc=coiby.xu@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=manishc@marvell.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).