From: Sevinj Aghayeva <sevinj.aghayeva@gmail.com>
To: aroulin@nvidia.com
Cc: sbrivio@redhat.com, roopa@nvidia.com,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Nikolay Aleksandrov <razor@blackwall.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
bridge@lists.linux-foundation.org,
Sevinj Aghayeva <sevinj.aghayeva@gmail.com>
Subject: [PATCH net-next 0/3] net: vlan: fix bridge binding behavior and add selftests
Date: Sat, 30 Jul 2022 12:03:29 -0400 [thread overview]
Message-ID: <cover.1659195179.git.sevinj.aghayeva@gmail.com> (raw)
When bridge binding is enabled for a vlan interface, it is expected
that the link state of the vlan interface will track the subset of the
ports that are also members of the corresponding vlan, rather than
that of all ports.
Currently, this feature works as expected when a vlan interface is
created with bridge binding enabled:
ip link add link br name vlan10 type vlan id 10 protocol 802.1q \
bridge_binding on
However, the feature does not work when a vlan interface is created
with bridge binding disabled, and then enabled later:
ip link add link br name vlan10 type vlan id 10 protocol 802.1q \
bridge_binding off
ip link set vlan10 type vlan bridge_binding on
After these two commands, the link state of the vlan interface
continues to track that of all ports, which is inconsistent and
confusing to users. This series fixes this bug and introduces two
tests for the valid behavior.
Sevinj Aghayeva (3):
net: bridge: export br_vlan_upper_change
net: 8021q: fix bridge binding behavior for vlan interfaces
selftests: net: tests for bridge binding behavior
include/linux/if_bridge.h | 9 ++
net/8021q/vlan.h | 2 +-
net/8021q/vlan_dev.c | 21 ++-
net/bridge/br_vlan.c | 7 +-
tools/testing/selftests/net/Makefile | 1 +
.../selftests/net/bridge_vlan_binding_test.sh | 143 ++++++++++++++++++
6 files changed, 176 insertions(+), 7 deletions(-)
create mode 100755 tools/testing/selftests/net/bridge_vlan_binding_test.sh
--
2.25.1
next reply other threads:[~2022-07-30 16:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-30 16:03 Sevinj Aghayeva [this message]
2022-07-30 16:03 ` [PATCH net-next 1/3] net: bridge: export br_vlan_upper_change Sevinj Aghayeva
2022-07-30 16:03 ` [PATCH net-next 2/3] net: 8021q: fix bridge binding behavior for vlan interfaces Sevinj Aghayeva
2022-07-30 19:58 ` kernel test robot
2022-07-30 20:18 ` kernel test robot
2022-07-30 20:18 ` kernel test robot
2022-07-30 16:03 ` [PATCH net-next 3/3] selftests: net: tests for bridge binding behavior Sevinj Aghayeva
2022-07-30 16:21 ` [PATCH net-next 0/3] net: vlan: fix bridge binding behavior and add selftests Nikolay Aleksandrov
[not found] ` <CAMWRUK5j4UAwjw4UGN=SVbbDbut0zWg5e03wupAXCPwT8K8zzQ@mail.gmail.com>
2022-07-30 16:48 ` Sevinj Aghayeva
2022-07-31 1:54 ` Roopa Prabhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1659195179.git.sevinj.aghayeva@gmail.com \
--to=sevinj.aghayeva@gmail.com \
--cc=aroulin@nvidia.com \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=razor@blackwall.org \
--cc=roopa@nvidia.com \
--cc=sbrivio@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).