From: Jonathan Toppins <jtoppins@redhat.com>
To: netdev@vger.kernel.org, jay.vosburgh@canonical.com
Cc: liuhangbin@gmail.com
Subject: [PATCH net v4 0/3] bonding: 802.3ad: fix no transmission of LACPDUs
Date: Thu, 18 Aug 2022 10:41:09 -0400 [thread overview]
Message-ID: <cover.1660832962.git.jtoppins@redhat.com> (raw)
Configuring a bond in a specific order can leave the bond in a state
where it never transmits LACPDUs.
The first patch adds some kselftest infrastructure and the reproducer
that demonstrates the problem. The second patch fixes the issue. The
new third patch makes ad_ticks_per_sec a static const and removes the
passing of this variable via the stack.
v4:
* rebased to latest net/master
* removed if check around bond_3ad_initialize function contents
* created a new patch that makes ad_ticks_per_sec a static const
v3:
* rebased to latest net/master
* addressed comment from Hangbin
Jonathan Toppins (3):
selftests: include bonding tests into the kselftest infra
bonding: 802.3ad: fix no transmission of LACPDUs
bonding: 3ad: make ad_ticks_per_sec a const
MAINTAINERS | 1 +
drivers/net/bonding/bond_3ad.c | 40 ++++-----
drivers/net/bonding/bond_main.c | 2 +-
include/net/bond_3ad.h | 2 +-
tools/testing/selftests/Makefile | 1 +
.../selftests/drivers/net/bonding/Makefile | 6 ++
.../net/bonding/bond-break-lacpdu-tx.sh | 81 +++++++++++++++++++
.../selftests/drivers/net/bonding/config | 1 +
.../selftests/drivers/net/bonding/settings | 1 +
9 files changed, 108 insertions(+), 27 deletions(-)
create mode 100644 tools/testing/selftests/drivers/net/bonding/Makefile
create mode 100755 tools/testing/selftests/drivers/net/bonding/bond-break-lacpdu-tx.sh
create mode 100644 tools/testing/selftests/drivers/net/bonding/config
create mode 100644 tools/testing/selftests/drivers/net/bonding/settings
--
2.31.1
next reply other threads:[~2022-08-18 14:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-18 14:41 Jonathan Toppins [this message]
2022-08-18 14:41 ` [PATCH net v4 1/3] selftests: include bonding tests into the kselftest infra Jonathan Toppins
2022-08-18 14:41 ` [PATCH net v4 2/3] bonding: 802.3ad: fix no transmission of LACPDUs Jonathan Toppins
2022-08-18 14:41 ` [PATCH net v4 3/3] bonding: 3ad: make ad_ticks_per_sec a const Jonathan Toppins
2022-08-19 3:57 ` Jakub Kicinski
2022-08-19 0:02 ` [PATCH net v4 0/3] bonding: 802.3ad: fix no transmission of LACPDUs Jay Vosburgh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1660832962.git.jtoppins@redhat.com \
--to=jtoppins@redhat.com \
--cc=jay.vosburgh@canonical.com \
--cc=liuhangbin@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).