netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Gustavo A. R. Silva" <gustavoars@kernel.org>
To: Kalle Valo <kvalo@kernel.org>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jouni Malinen <j@w1.fi>,
	Stanislav Yakovlev <stas.yakovlev@gmail.com>,
	Johannes Berg <johannes@sipsolutions.net>
Cc: netdev@vger.kernel.org, linux-wireless@vger.kernel.org,
	linux-kernel@vger.kernel.org, Kees Cook <keescook@chromium.org>,
	"Gustavo A. R. Silva" <gustavoars@kernel.org>,
	linux-hardening@vger.kernel.org
Subject: [PATCH v3 0/7] Avoid clashing function prototypes
Date: Tue, 8 Nov 2022 14:18:05 -0600	[thread overview]
Message-ID: <cover.1667934775.git.gustavoars@kernel.org> (raw)

When built with Control Flow Integrity, function prototypes between
caller and function declaration must match. These mismatches are visible
at compile time with the new -Wcast-function-type-strict in Clang[1].

This series fixes a total of 424 -Wcast-function-type-strict warnings.

Link: https://reviews.llvm.org/D134831 [1]

Changes in v3:
 - Split non-related orinoco changes out of cgf80211 into a separate
   patch.
 - Mention Coccinelle in some of the patches where it was used
   to make some changes.
 - Add RB tags to a couple of patches.

Changes in v2:
 - Squash patches 1, 2 and 3 into a single patch cfg80211.
 - Add a couple more patches: bna and staging.
 - Fix 254 (227 in bna and 27 in staging) more
   -Wcast-function-type-strict warnings.
 - Link: https://lore.kernel.org/linux-hardening/cover.1666894751.git.gustavoars@kernel.org/

v1:
 - Link: https://lore.kernel.org/linux-hardening/cover.1666038048.git.gustavoars@kernel.org/

Gustavo A. R. Silva (7):
  wifi: orinoco: Avoid clashing function prototypes
  cfg80211: Avoid clashing function prototypes
  wifi: hostap: Avoid clashing function prototypes
  wifi: zd1201: Avoid clashing function prototypes
  wifi: airo: Avoid clashing function prototypes
  bna: Avoid clashing function prototypes
  staging: ks7010: Avoid clashing function prototypes

 drivers/net/ethernet/brocade/bna/bfa_cs.h     |  60 +++--
 drivers/net/ethernet/brocade/bna/bfa_ioc.c    |  10 +-
 drivers/net/ethernet/brocade/bna/bfa_ioc.h    |   8 +-
 drivers/net/ethernet/brocade/bna/bfa_msgq.h   |   8 +-
 drivers/net/ethernet/brocade/bna/bna_enet.c   |   6 +-
 drivers/net/ethernet/brocade/bna/bna_tx_rx.c  |   6 +-
 drivers/net/ethernet/brocade/bna/bna_types.h  |  27 +-
 drivers/net/wireless/cisco/airo.c             | 204 +++++++-------
 drivers/net/wireless/intel/ipw2x00/ipw2200.c  |   2 +-
 .../wireless/intersil/hostap/hostap_ioctl.c   | 244 +++++++++--------
 drivers/net/wireless/intersil/orinoco/wext.c  | 131 +++++----
 drivers/net/wireless/zydas/zd1201.c           | 174 ++++++------
 drivers/staging/ks7010/ks_wlan_net.c          | 248 +++++++++---------
 include/net/cfg80211-wext.h                   |  20 +-
 net/wireless/scan.c                           |   3 +-
 net/wireless/wext-compat.c                    | 180 ++++++-------
 net/wireless/wext-compat.h                    |   8 +-
 net/wireless/wext-sme.c                       |   5 +-
 18 files changed, 713 insertions(+), 631 deletions(-)

-- 
2.34.1


             reply	other threads:[~2022-11-08 20:18 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-08 20:18 Gustavo A. R. Silva [this message]
2022-11-08 20:21 ` [PATCH v3 1/7] wifi: orinoco: Avoid clashing function prototypes Gustavo A. R. Silva
2022-11-10  0:06   ` Kees Cook
2022-11-16  9:32   ` Kalle Valo
2022-11-08 20:23 ` [PATCH v3 2/7] cfg80211: " Gustavo A. R. Silva
2022-11-10  0:06   ` Kees Cook
2022-11-08 20:25 ` [PATCH v3 3/7] wifi: hostap: " Gustavo A. R. Silva
2022-11-10  0:07   ` Kees Cook
2022-11-08 20:26 ` [PATCH v3 4/7] wifi: zd1201: " Gustavo A. R. Silva
2022-11-08 20:27 ` [PATCH v3 5/7] wifi: airo: " Gustavo A. R. Silva
2022-11-08 20:31 ` [PATCH v3 6/7] bna: " Gustavo A. R. Silva
2022-11-10  5:43   ` Kalle Valo
2022-11-11 16:46     ` Gustavo A. R. Silva

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1667934775.git.gustavoars@kernel.org \
    --to=gustavoars@kernel.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=j@w1.fi \
    --cc=johannes@sipsolutions.net \
    --cc=keescook@chromium.org \
    --cc=kuba@kernel.org \
    --cc=kvalo@kernel.org \
    --cc=linux-hardening@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=stas.yakovlev@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).