From: Jonathan Toppins <jtoppins@redhat.com>
To: "netdev @ vger . kernel . org" <netdev@vger.kernel.org>,
pabeni@redhat.com
Cc: Jay Vosburgh <j.vosburgh@gmail.com>
Subject: [PATCH net-next v2 0/2] bonding: fix bond recovery in mode 2
Date: Tue, 22 Nov 2022 15:25:03 -0500 [thread overview]
Message-ID: <cover.1669147951.git.jtoppins@redhat.com> (raw)
When a bond is configured with a non-zero updelay and in mode 2 the bond
never recovers after all slaves lose link. The first patch adds
selftests that demonstrate the issue and the second patch fixes the
issue by ignoring the updelay when there are no usable slaves.
v2:
* repost to net tree, suggested by Paolo Abeni
* reduce number of icmp echos used in test, suggested by Paolo Abeni
Jonathan Toppins (2):
selftests: bonding: up/down delay w/ slave link flapping
bonding: fix link recovery in mode 2 when updelay is nonzero
drivers/net/bonding/bond_main.c | 11 +-
.../selftests/drivers/net/bonding/Makefile | 4 +-
.../selftests/drivers/net/bonding/lag_lib.sh | 106 ++++++++++++++++++
.../net/bonding/mode-1-recovery-updelay.sh | 45 ++++++++
.../net/bonding/mode-2-recovery-updelay.sh | 45 ++++++++
.../selftests/drivers/net/bonding/settings | 2 +-
6 files changed, 210 insertions(+), 3 deletions(-)
create mode 100755 tools/testing/selftests/drivers/net/bonding/mode-1-recovery-updelay.sh
create mode 100755 tools/testing/selftests/drivers/net/bonding/mode-2-recovery-updelay.sh
--
2.31.1
next reply other threads:[~2022-11-22 20:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-22 20:25 Jonathan Toppins [this message]
2022-11-22 20:25 ` [PATCH net-next v2 1/2] selftests: bonding: up/down delay w/ slave link flapping Jonathan Toppins
2022-11-22 21:24 ` [PATCH net-next v2 2/2] bonding: fix link recovery in mode 2 when updelay is nonzero Jonathan Toppins
2022-11-23 6:25 ` Jay Vosburgh
2022-11-24 4:20 ` [PATCH net-next v2 0/2] bonding: fix bond recovery in mode 2 patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1669147951.git.jtoppins@redhat.com \
--to=jtoppins@redhat.com \
--cc=j.vosburgh@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).