netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Daniel Golle <daniel@makrotopia.org>
To: netdev@vger.kernel.org, linux-mediatek@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Vladimir Oltean <olteanv@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	AngeloGioacchino Del Regno 
	<angelogioacchino.delregno@collabora.com>,
	Sean Wang <sean.wang@mediatek.com>,
	Landen Chao <Landen.Chao@mediatek.com>,
	DENG Qingfang <dqfext@gmail.com>,
	Philipp Zabel <p.zabel@pengutronix.de>
Cc: Sam Shih <Sam.Shih@mediatek.com>,
	Lorenzo Bianconi <lorenzo@kernel.org>,
	John Crispin <john@phrozen.org>, Felix Fietkau <nbd@nbd.name>
Subject: [RFC PATCH net-next v3 00/15] net: dsa: add support for MT7988
Date: Wed, 29 Mar 2023 16:57:04 +0100	[thread overview]
Message-ID: <cover.1680105013.git.daniel@makrotopia.org> (raw)

The MediaTek MT7988 SoC comes with a built-in switch very similar to
previous MT7530 and MT7531. However, the switch address space is mapped
into the SoCs memory space rather than being connected via MDIO.
Using MMIO simplifies register access and also removes the need for a bus
lock, and for that reason also makes interrupt handling more light-weight.

Note that this is different from previous SoCs like MT7621 and MT7623N
which also came with an integrated MT7530-like switch which yet had to be
accessed via MDIO.

Split-off the part of the driver registering an MDIO driver, then add
another module acting as MMIO/platform driver.

Changes since v2:
 * split into many small commits to ease review
 * introduce helper functions to reduce code duplication
 * use helpers for locking to make lock-skipping easier and less ugly
   to implement.
 * add dt-bindings for mediatek,mt7988-switch

Changes since initial RFC:
 * use regmap for register access and move register access to bus-
   specific driver
 * move initialization of MT7531 SGMII PCS to MDIO driver

Daniel Golle (15):
  net: dsa: mt7530: refactor SGMII PCS creation
  net: dsa: mt7530: use unlocked regmap accessors
  net: dsa: mt7530: use regmap to access switch register space
  net: dsa: mt7530: move SGMII PCS creation to mt7530_probe function
  net: dsa: mt7530: introduce mutex helpers
  net: dsa: mt7530: move p5_intf_modes() function to mt7530.c
  net: dsa: mt7530: introduce mt7530_probe_common helper function
  net: dsa: mt7530: introduce mt7530_remove_common helper function
  net: dsa: mt7530: split-off common parts from mt7531_setup
  net: dsa: mt7530: introduce separate MDIO driver
  net: dsa: mt7530: skip locking if MDIO bus isn't present
  net: dsa: mt7530: add support for single-chip reset line
  net: dsa: mt7530: add support for 10G link modes for CPU port
  net: dsa: mt7530: introduce driver for MT7988 built-in switch
  dt-bindings: net: dsa: mediatek,mt7530: add mediatek,mt7988-switch

 .../bindings/net/dsa/mediatek,mt7530.yaml     |  26 +-
 MAINTAINERS                                   |   3 +
 drivers/net/dsa/Kconfig                       |  28 +-
 drivers/net/dsa/Makefile                      |   4 +-
 drivers/net/dsa/mt7530-mdio.c                 | 242 ++++++++
 drivers/net/dsa/mt7530-mmio.c                 |  96 ++++
 drivers/net/dsa/mt7530.c                      | 519 +++++++++---------
 drivers/net/dsa/mt7530.h                      |  38 +-
 8 files changed, 653 insertions(+), 303 deletions(-)
 create mode 100644 drivers/net/dsa/mt7530-mdio.c
 create mode 100644 drivers/net/dsa/mt7530-mmio.c


base-commit: 86e2eca4ddedc07d639c44c990e1c220cac3741e
-- 
2.39.2


             reply	other threads:[~2023-03-29 15:58 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-29 15:57 Daniel Golle [this message]
2023-03-29 15:57 ` [RFC PATCH net-next v3 01/15] net: dsa: mt7530: refactor SGMII PCS creation Daniel Golle
2023-03-29 15:57 ` [RFC PATCH net-next v3 02/15] net: dsa: mt7530: use unlocked regmap accessors Daniel Golle
2023-03-29 15:57 ` [RFC PATCH net-next v3 03/15] net: dsa: mt7530: use regmap to access switch register space Daniel Golle
2023-03-29 16:24   ` Andrew Lunn
2023-03-29 18:33     ` Daniel Golle
2023-03-29 19:35       ` Andrew Lunn
2023-03-29 15:58 ` [RFC PATCH net-next v3 04/15] net: dsa: mt7530: move SGMII PCS creation to mt7530_probe function Daniel Golle
2023-03-29 15:58 ` [RFC PATCH net-next v3 05/15] net: dsa: mt7530: introduce mutex helpers Daniel Golle
2023-03-29 16:27   ` Andrew Lunn
2023-03-29 15:58 ` [RFC PATCH net-next v3 06/15] net: dsa: mt7530: move p5_intf_modes() function to mt7530.c Daniel Golle
2023-03-29 16:28   ` Andrew Lunn
2023-03-29 15:58 ` [RFC PATCH net-next v3 07/15] net: dsa: mt7530: introduce mt7530_probe_common helper function Daniel Golle
2023-03-29 16:34   ` Andrew Lunn
2023-03-29 15:59 ` [RFC PATCH net-next v3 08/15] net: dsa: mt7530: introduce mt7530_remove_common " Daniel Golle
2023-03-29 16:34   ` Andrew Lunn
2023-03-29 15:59 ` [RFC PATCH net-next v3 09/15] net: dsa: mt7530: split-off common parts from mt7531_setup Daniel Golle
2023-03-29 16:35   ` Andrew Lunn
2023-03-29 15:59 ` [RFC PATCH net-next v3 10/15] net: dsa: mt7530: introduce separate MDIO driver Daniel Golle
2023-03-29 16:38   ` Andrew Lunn
2023-03-29 15:59 ` [RFC PATCH net-next v3 11/15] net: dsa: mt7530: skip locking if MDIO bus isn't present Daniel Golle
2023-03-29 16:39   ` Andrew Lunn
2023-03-29 16:00 ` [RFC PATCH net-next v3 12/15] net: dsa: mt7530: add support for single-chip reset line Daniel Golle
2023-03-29 16:44   ` Andrew Lunn
2023-03-29 16:00 ` [RFC PATCH net-next v3 13/15] net: dsa: mt7530: add support for 10G link modes for CPU port Daniel Golle
2023-03-29 16:48   ` Andrew Lunn
2023-03-29 16:00 ` [RFC PATCH net-next v3 14/15] net: dsa: mt7530: introduce driver for MT7988 built-in switch Daniel Golle
2023-03-29 16:57   ` Andrew Lunn
2023-03-29 19:05     ` Daniel Golle
2023-03-29 16:02 ` [RFC PATCH net-next v3 15/15] dt-bindings: net: dsa: mediatek,mt7530: add mediatek,mt7988-switch Daniel Golle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1680105013.git.daniel@makrotopia.org \
    --to=daniel@makrotopia.org \
    --cc=Landen.Chao@mediatek.com \
    --cc=Sam.Shih@mediatek.com \
    --cc=andrew@lunn.ch \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=davem@davemloft.net \
    --cc=dqfext@gmail.com \
    --cc=edumazet@google.com \
    --cc=f.fainelli@gmail.com \
    --cc=john@phrozen.org \
    --cc=kuba@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=lorenzo@kernel.org \
    --cc=matthias.bgg@gmail.com \
    --cc=nbd@nbd.name \
    --cc=netdev@vger.kernel.org \
    --cc=olteanv@gmail.com \
    --cc=p.zabel@pengutronix.de \
    --cc=pabeni@redhat.com \
    --cc=sean.wang@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).