netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Leon Romanovsky <leon@kernel.org>
To: Steffen Klassert <steffen.klassert@secunet.com>
Cc: Leon Romanovsky <leonro@nvidia.com>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	netdev@vger.kernel.org, Patrisious Haddad <phaddad@nvidia.com>,
	Raed Salem <raeds@nvidia.com>, Saeed Mahameed <saeedm@nvidia.com>
Subject: [PATCH xfrm-next 0/9] mlx5 IPsec replay window enhancement and XFRM core statistics
Date: Mon, 16 Oct 2023 12:15:08 +0300	[thread overview]
Message-ID: <cover.1697444728.git.leon@kernel.org> (raw)

From: Leon Romanovsky <leonro@nvidia.com>

Hi,

This series does two things at the same time, but they are connected together:
 * Rewrite and fix mlx5 IPsec replay window implementation.
 * Connect XFRM statistics with offloaded counters to report replay window
   reason statistics.

First two patches are XFRM core changes to allow reuse of already existing
callback to fill all statistics.

Next two patches are fixes to replay window and sequence packet number
misconfiguration. They are not urgent and can go to -next.

Rest of the patches are rewrite of mlx5 replay window implementation.

As an example, the end result, after simulating replay window attack with 5 packets:
[leonro@c ~]$ grep XfrmInStateSeqError /proc/net/xfrm_stat
XfrmInStateSeqError     	5
[leonro@c ~]$ sudo ip -s x s
<...>
	stats:
	  replay-window 0 replay 5 failed 0

Thanks

Leon Romanovsky (7):
  xfrm: generalize xdo_dev_state_update_curlft to allow statistics
    update
  xfrm: get global statistics from the offloaded device
  net/mlx5e: Honor user choice of IPsec replay window size
  net/mlx5e: Ensure that IPsec sequence packet number starts from 1
  net/mlx5e: Remove exposure of IPsec RX flow steering struct
  net/mlx5e: Connect mlx5 IPsec statistics with XFRM core
  net/mlx5e: Delete obsolete IPsec code

Patrisious Haddad (2):
  net/mlx5e: Unify esw and normal IPsec status table
    creation/destruction
  net/mlx5e: Add IPsec and ASO syndromes check in HW

 Documentation/networking/xfrm_device.rst      |   4 +-
 .../mellanox/mlx5/core/en_accel/ipsec.c       |  57 ++-
 .../mellanox/mlx5/core/en_accel/ipsec.h       |  23 +-
 .../mellanox/mlx5/core/en_accel/ipsec_fs.c    | 410 +++++++++++++++---
 .../mlx5/core/en_accel/ipsec_offload.c        |   2 +-
 .../mellanox/mlx5/core/en_accel/ipsec_rxtx.c  |  25 +-
 .../mellanox/mlx5/core/en_accel/ipsec_rxtx.h  |   1 -
 .../mellanox/mlx5/core/en_accel/ipsec_stats.c |   1 -
 .../mellanox/mlx5/core/esw/ipsec_fs.c         | 160 +------
 .../mellanox/mlx5/core/esw/ipsec_fs.h         |  15 -
 include/linux/mlx5/mlx5_ifc.h                 |   7 +
 include/linux/netdevice.h                     |   2 +-
 include/net/xfrm.h                            |  14 +-
 net/xfrm/xfrm_proc.c                          |   1 +
 net/xfrm/xfrm_state.c                         |  17 +-
 net/xfrm/xfrm_user.c                          |   2 +-
 16 files changed, 459 insertions(+), 282 deletions(-)

-- 
2.41.0


             reply	other threads:[~2023-10-16  9:15 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-16  9:15 Leon Romanovsky [this message]
2023-10-16  9:15 ` [PATCH xfrm-next 1/9] xfrm: generalize xdo_dev_state_update_curlft to allow statistics update Leon Romanovsky
2023-10-16  9:15 ` [PATCH xfrm-next 2/9] xfrm: get global statistics from the offloaded device Leon Romanovsky
2023-10-16  9:15 ` [PATCH xfrm-next 3/9] net/mlx5e: Honor user choice of IPsec replay window size Leon Romanovsky
2023-10-16  9:15 ` [PATCH xfrm-next 4/9] net/mlx5e: Ensure that IPsec sequence packet number starts from 1 Leon Romanovsky
2023-10-16  9:15 ` [PATCH xfrm-next 5/9] net/mlx5e: Unify esw and normal IPsec status table creation/destruction Leon Romanovsky
2023-10-17  9:38   ` Steffen Klassert
2023-10-17 12:13     ` Leon Romanovsky
2023-10-18  5:13       ` Leon Romanovsky
2023-10-19  8:46       ` Steffen Klassert
2023-10-19 11:01         ` Leon Romanovsky
2023-10-16  9:15 ` [PATCH xfrm-next 6/9] net/mlx5e: Remove exposure of IPsec RX flow steering struct Leon Romanovsky
2023-10-16  9:15 ` [PATCH xfrm-next 7/9] net/mlx5e: Add IPsec and ASO syndromes check in HW Leon Romanovsky
2023-10-16  9:15 ` [PATCH xfrm-next 8/9] net/mlx5e: Connect mlx5 IPsec statistics with XFRM core Leon Romanovsky
2023-10-16  9:15 ` [PATCH xfrm-next 9/9] net/mlx5e: Delete obsolete IPsec code Leon Romanovsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1697444728.git.leon@kernel.org \
    --to=leon@kernel.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=leonro@nvidia.com \
    --cc=netdev@vger.kernel.org \
    --cc=phaddad@nvidia.com \
    --cc=raeds@nvidia.com \
    --cc=saeedm@nvidia.com \
    --cc=steffen.klassert@secunet.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).