netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
To: dchickles@marvell.com, sburla@marvell.com, fmanlunas@marvell.com,
	davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
	pabeni@redhat.com, veerasenareddy.burru@cavium.com
Cc: felix.manlunas@cavium.com, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
	Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Subject: [PATCH net 0/2] liquidio: Fix an off by one in octeon_download_firmware()
Date: Sun, 22 Oct 2023 22:59:45 +0200	[thread overview]
Message-ID: <cover.1698007858.git.christophe.jaillet@wanadoo.fr> (raw)

This serie fixes an off by one related to the usage of strncat() in
octeon_download_firmware().

The first patch is a minimal fix.

The 2nd one is an attempt to remove strncat() which is used in a wrong way
most of the time.
It removes the need of an intermediate buffer but may need further discussions.
(i.e. is it a good idea to update h->bootcmd directly?)

Both patches are compile tested only.

Christophe JAILLET (2):
  liquidio: Fix an off by one in octeon_download_firmware()
  liquidio: Simplify octeon_download_firmware()

 .../net/ethernet/cavium/liquidio/octeon_console.c   | 13 +++++--------
 1 file changed, 5 insertions(+), 8 deletions(-)

-- 
2.34.1


             reply	other threads:[~2023-10-22 21:00 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-22 20:59 Christophe JAILLET [this message]
2023-10-22 20:59 ` [PATCH net 1/2] liquidio: Fix an off by one in octeon_download_firmware() Christophe JAILLET
2023-10-22 20:59 ` [PATCH net 2/2] liquidio: Simplify octeon_download_firmware() Christophe JAILLET
2023-10-24  0:29   ` Jacob Keller
2023-10-24 11:11   ` Paolo Abeni
2023-10-24 12:10     ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1698007858.git.christophe.jaillet@wanadoo.fr \
    --to=christophe.jaillet@wanadoo.fr \
    --cc=davem@davemloft.net \
    --cc=dchickles@marvell.com \
    --cc=edumazet@google.com \
    --cc=felix.manlunas@cavium.com \
    --cc=fmanlunas@marvell.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=sburla@marvell.com \
    --cc=veerasenareddy.burru@cavium.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).