From: Pavel Begunkov <asml.silence@gmail.com>
To: netdev@vger.kernel.org, edumazet@google.com, davem@davemloft.net,
dsahern@kernel.org, pabeni@redhat.com, kuba@kernel.org
Cc: Pavel Begunkov <asml.silence@gmail.com>
Subject: [RFC 0/2] optimise UDP skb completion wakeups
Date: Wed, 7 Feb 2024 14:23:40 +0000 [thread overview]
Message-ID: <cover.1707138546.git.asml.silence@gmail.com> (raw)
sock_wfree() tries to wake even when there are only read waiters and no
write waiters, which is the common scenario for io_uring. It'd also
attempt to wake if the write queue is far from being full. To avoid most
of this overhead add SOCK_NOSPACE support for UDP.
It brings +5% to UDP throughput with a CPU bound benchmark, and I observed
it taking 0.5-2% according to profiles in more realistic workloads.
Patch 1 introduces a new destructor udp_wfree(). The optimisation can be
implemented in sock_wfree() but that would either require patching up all
poll callbacks across the tree that are used in couple with sock_wfree(),
or limiting it to UDP with a flag.
Another option considered was to split out a write waitqueue, perhaps
conditionally, but it's bulkier, and the current version should also
benefit epoll workloads.
Pavel Begunkov (2):
udp: introduce udp specific skb destructor
udp: optimise write wakeups with SOCK_NOSPACE
drivers/net/veth.c | 10 +++++---
include/net/sock.h | 1 +
include/net/udp.h | 1 +
net/core/sock.c | 10 +++++---
net/ipv4/udp.c | 58 ++++++++++++++++++++++++++++++++++++++++++++--
net/ipv6/udp.c | 5 +++-
6 files changed, 76 insertions(+), 9 deletions(-)
--
2.43.0
next reply other threads:[~2024-02-07 14:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-07 14:23 Pavel Begunkov [this message]
2024-02-07 14:23 ` [RFC 1/2] udp: introduce udp specific skb destructor Pavel Begunkov
2024-02-07 14:23 ` [RFC 2/2] udp: optimise write wakeups with SOCK_NOSPACE Pavel Begunkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1707138546.git.asml.silence@gmail.com \
--to=asml.silence@gmail.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).