From: Sabrina Dubroca <sd@queasysnail.net>
To: netdev@vger.kernel.org
Cc: Sabrina Dubroca <sd@queasysnail.net>,
Boris Pismenny <borisp@nvidia.com>,
John Fastabend <john.fastabend@gmail.com>,
Jakub Kicinski <kuba@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Shuah Khan <shuah@kernel.org>,
Vakul Garg <vakul.garg@nxp.com>,
linux-kselftest@vger.kernel.org
Subject: [PATCH net 0/5] tls: fixes for record type handling with PEEK
Date: Thu, 15 Feb 2024 17:17:28 +0100 [thread overview]
Message-ID: <cover.1708007371.git.sd@queasysnail.net> (raw)
There are multiple bugs in tls_sw_recvmsg's handling of record types
when MSG_PEEK flag is used, which can lead to incorrectly merging two
records:
- consecutive non-DATA records shouldn't be merged, even if they're
the same type (partly handled by the test at the end of the main
loop)
- records of the same type (even DATA) shouldn't be merged if one
record of a different type comes in between
Sabrina Dubroca (5):
tls: break out of main loop when PEEK gets a non-data record
tls: stop recv() if initial process_rx_list gave us non-DATA
tls: don't skip over different type records from the rx_list
selftests: tls: add test for merging of same-type control messages
selftests: tls: add test for peeking past a record of a different type
net/tls/tls_sw.c | 24 +++++++++++------
tools/testing/selftests/net/tls.c | 45 +++++++++++++++++++++++++++++++
2 files changed, 61 insertions(+), 8 deletions(-)
--
2.43.0
next reply other threads:[~2024-02-15 16:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-15 16:17 Sabrina Dubroca [this message]
2024-02-15 16:17 ` [PATCH net 1/5] tls: break out of main loop when PEEK gets a non-data record Sabrina Dubroca
2024-02-15 16:17 ` [PATCH net 2/5] tls: stop recv() if initial process_rx_list gave us non-DATA Sabrina Dubroca
2024-02-15 16:17 ` [PATCH net 3/5] tls: don't skip over different type records from the rx_list Sabrina Dubroca
2024-02-19 20:07 ` Jakub Kicinski
2024-02-19 23:10 ` Sabrina Dubroca
2024-02-21 1:50 ` Jakub Kicinski
2024-02-21 13:59 ` Sabrina Dubroca
2024-02-21 18:33 ` Jakub Kicinski
2024-02-21 18:42 ` Sabrina Dubroca
2024-02-15 16:17 ` [PATCH net 4/5] selftests: tls: add test for merging of same-type control messages Sabrina Dubroca
2024-02-15 16:17 ` [PATCH net 5/5] selftests: tls: add test for peeking past a record of a different type Sabrina Dubroca
2024-02-21 22:30 ` [PATCH net 0/5] tls: fixes for record type handling with PEEK patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1708007371.git.sd@queasysnail.net \
--to=sd@queasysnail.net \
--cc=borisp@nvidia.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
--cc=vakul.garg@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).