netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Balazs Scheidler <bazsi77@gmail.com>
To: kerneljasonxing@gmail.com, kuniyu@amazon.com, netdev@vger.kernel.org
Cc: Balazs Scheidler <balazs.scheidler@axoflow.com>
Subject: [PATCH net-next v3 0/2] Add IP/port information to UDP drop tracepoint
Date: Tue, 26 Mar 2024 19:05:45 +0100	[thread overview]
Message-ID: <cover.1711475011.git.balazs.scheidler@axoflow.com> (raw)

Hi,

In our use-case we would like to recover the properties of dropped UDP
packets. Unfortunately the current udp_fail_queue_rcv_skb tracepoint
only exposes the port number of the receiving socket.

This patch-set will add the source/dest ip/port to the tracepoint, while 
keeping the socket's local port as well for compatibility.

Thanks for the review comments by Jason and Kuniyuki, they helped me a lot
and I tried to address all of their comments in this new iteration.

v4 updates:
  * fixed checkpatch.pl warnings
  * rebased against latest net-next

v3 updates:
  * Dropped "lport" as suggested by Jason Xing <kerneljasonxing@gmail.com>
  * Clear saddr/daddr fields using memset() before populating the fields as
    suggested by Jason Xing.

v2 updates:
  * Addressed review notes by Kuniyuki Iwashima <kuniyu@amazon.com>

Balazs Scheidler (2):
  net: port TP_STORE_ADDR_PORTS_SKB macro to be tcp/udp independent
  net: udp: add IP/port data to the tracepoint
    udp/udp_fail_queue_rcv_skb

 include/trace/events/net_probe_common.h | 40 ++++++++++++++++++++++
 include/trace/events/tcp.h              | 45 ++-----------------------
 include/trace/events/udp.h              | 29 +++++++++++++---
 net/ipv4/udp.c                          |  2 +-
 net/ipv6/udp.c                          |  3 +-
 5 files changed, 69 insertions(+), 50 deletions(-)

-- 
2.40.1


             reply	other threads:[~2024-03-26 18:05 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-26 18:05 Balazs Scheidler [this message]
2024-03-26 18:05 ` [PATCH net-next v4 1/2] net: port TP_STORE_ADDR_PORTS_SKB macro to be tcp/udp independent Balazs Scheidler
2024-03-26 18:05 ` [PATCH net-next v4 2/2] net: udp: add IP/port data to the tracepoint udp/udp_fail_queue_rcv_skb Balazs Scheidler
2024-03-27  6:56   ` Jason Xing
2024-03-29 19:30 ` [PATCH net-next v3 0/2] Add IP/port information to UDP drop tracepoint patchwork-bot+netdevbpf
  -- strict thread matches above, loose matches on Subject: below --
2024-03-25 10:29 Balazs Scheidler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1711475011.git.balazs.scheidler@axoflow.com \
    --to=bazsi77@gmail.com \
    --cc=balazs.scheidler@axoflow.com \
    --cc=kerneljasonxing@gmail.com \
    --cc=kuniyu@amazon.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).